From patchwork Tue Jul 10 00:09:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169988 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 002712C0209 for ; Tue, 10 Jul 2012 10:09:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176Ab2GJAJP (ORCPT ); Mon, 9 Jul 2012 20:09:15 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56424 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754938Ab2GJAJN (ORCPT ); Mon, 9 Jul 2012 20:09:13 -0400 Received: by mail-pb0-f46.google.com with SMTP id rp8so20018595pbb.19 for ; Mon, 09 Jul 2012 17:09:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=8JRuGCwFIry9za7KC71ELQwtNBdIwM+6kXR76yoqBoU=; b=eZcqyUQVRgQZbdEKYZyY9lyuC6i/z6GRF/AffLc2hZXEW/MM+8Y9rjp6weHlHlP0PK wZShQNsF4dT8areAN0hd656HCaaXy2Zn6REX9WAZhGZ+Q4A0Jgph6XDecRPw43wZZO2X GALDVzhkZzcXwDmjRYZ8Gg07a1+MW7l6TsWNqDGjvofBJjV6jXb1C75a/E9rt6UF6Q46 jPcNr2ILBllhnWWylQ6cKddiM8Az2nBwbxJO3q/AkbXh46Ru7mgAQPRDnxIPEg3PRNY2 9p4H0Gnpq1Al2c8UbmxC1f4/GAVFMoffkFcpcNpn8LUxONkoVfo+9ofSpp1ELPm4V3M6 yYcw== Received: by 10.68.209.197 with SMTP id mo5mr63811269pbc.72.1341878953615; Mon, 09 Jul 2012 17:09:13 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id or5sm9261842pbb.44.2012.07.09.17.09.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:12 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:09:45 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org, Sony Chacko , Rajesh Borundia Subject: [PATCH 03/11] netxen: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:27 -0700 Message-Id: <1341878975-10577-3-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> References: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Gm-Message-State: ALoCoQkIU6f52E9rcIC1qwBiCZBlkZnfLztOpUXqRRLnCHRJx/C2BNJKfmxg/jVtAUhgDuZuyS4+ Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set by the driver on packet recieve. eth_type_trans already sets skb->dev to the proper value and it is not referenced anywhere else in the dirver, thus making its setting unnecessary. Signed-off-by: Jon Mason Cc: Sony Chacko Cc: Rajesh Borundia --- .../net/ethernet/qlogic/netxen/netxen_nic_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index 8694124..b2c1b676 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -1532,8 +1532,6 @@ static struct sk_buff *netxen_process_rxbuf(struct netxen_adapter *adapter, } else skb->ip_summed = CHECKSUM_NONE; - skb->dev = adapter->netdev; - buffer->skb = NULL; no_skb: buffer->state = NETXEN_BUFFER_FREE;