From patchwork Tue Jul 10 00:09:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169996 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7191C2C0205 for ; Tue, 10 Jul 2012 10:09:58 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218Ab2GJAJ4 (ORCPT ); Mon, 9 Jul 2012 20:09:56 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:42042 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755167Ab2GJAJy (ORCPT ); Mon, 9 Jul 2012 20:09:54 -0400 Received: by mail-gg0-f174.google.com with SMTP id u4so10719391ggl.19 for ; Mon, 09 Jul 2012 17:09:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=pe9tYXf+YjTEnQJdJpFkStRpukvi5ruOnzBl1qiH+8k=; b=LodkbRZVaPFmKSyzfXU25WCKOrBseJWzkTQRxnBlnM1bu2I+TwZqYLuVwIuz+UV8/i 0k0rqZFoZtg4CWLxRJHSr7/0TYaeaD9msIgyWxsUCxmWLO7FVPpkC7a3aonYqgK570W5 tF9yomkzXi7arSOaiA0bd5IQMNivtu1G05QmcjqkHRmrsz9g8uJO/z6pC4scdB+dwZT7 NvbFsJIiLvpHOmdc2FXTtgJ3kMwokqlyPaikKno4y9nXz+C43VNLcGqFLN6znqzpQtJr hau90GW++Ims5hSeC55eIaM4hrBQ7+5z0J1dA5+VuKCK7p+ckTO8Lv92Fhr02tHf3TXH OK8w== Received: by 10.66.76.134 with SMTP id k6mr69049399paw.58.1341878994158; Mon, 09 Jul 2012 17:09:54 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id ku7sm28644771pbc.31.2012.07.09.17.09.51 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:53 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:10:26 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 11/11] ll_temac: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:35 -0700 Message-Id: <1341878975-10577-11-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> References: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Gm-Message-State: ALoCoQkCnPzJtz4TLVRmkBjPqZEPvDR3k6RvRz6mSgwZCLzkbhI40gOs07DWy7aKvbKZUCZ20/DX Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set by the driver on packet recieve. eth_type_trans already sets skb->dev to the proper value and it is not referenced anywhere else in the dirver, thus making its setting unnecessary. Signed-off-by: Jon Mason --- drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 1eaf712..705146d 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -768,7 +768,6 @@ static void ll_temac_recv(struct net_device *ndev) DMA_FROM_DEVICE); skb_put(skb, length); - skb->dev = ndev; skb->protocol = eth_type_trans(skb, ndev); skb_checksum_none_assert(skb);