From patchwork Tue Jul 10 00:09:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169997 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 081D22C0205 for ; Tue, 10 Jul 2012 10:10:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225Ab2GJAKF (ORCPT ); Mon, 9 Jul 2012 20:10:05 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56424 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755148Ab2GJAJD (ORCPT ); Mon, 9 Jul 2012 20:09:03 -0400 Received: by pbbrp8 with SMTP id rp8so20018595pbb.19 for ; Mon, 09 Jul 2012 17:09:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=8tQLRLOThCnUiKhb+90e0Uuoq5CT/FyzNA2ui1dzApU=; b=AuT/6WM7pxyffpDTLdz68Tu974EFpTzn1nr33cl+rcbkwpFniu0CUcsNHcy7oGWu0g S4m67+hC1K4W1n6maDASxamhIz4OPCakV8Gq/tCrnpSFhVJrK1ZxNRC9oftZl9vJ1ZFf zOHntrarM7MMrNwI/rvB55x1UXvR1siKoovjBZCIXWrQLKh3n4ofMuuo6mx2OZ9uRkFr dc/ocazqYvPK9qP+A5oRT/BO4ikMtt7PaUMdzEbvSydfTtaybEbPEJvjsmHQFbqLUHMN ljEgWK30dcx6yn02r3Wzod9M7hoJTVK4cv7bCnB7XB5tfAZN4Zqd21twhnrNB5Mim4Cf CSIA== Received: by 10.68.221.41 with SMTP id qb9mr63958381pbc.147.1341878943048; Mon, 09 Jul 2012 17:09:03 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id io2sm28649014pbc.24.2012.07.09.17.09.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:02 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:09:35 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 01/11] lance: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:25 -0700 Message-Id: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQlnvCfKcdVI7Lln0HuHv/r8/L5VGe9+Hwr/N2ATMO6v36aZj73nzEOLSsMJu15ZRDmXxr/g Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set during ring init. It is already being set to the proper value when eth_type_trans is called on packet receive, and the skb->dev is not referenced anywhere else in the code. Signed-off-by: Jon Mason --- drivers/net/ethernet/amd/lance.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c index a6e2e84..5c72843 100644 --- a/drivers/net/ethernet/amd/lance.c +++ b/drivers/net/ethernet/amd/lance.c @@ -873,10 +873,9 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); lp->rx_skbuff[i] = skb; - if (skb) { - skb->dev = dev; + if (skb) rx_buff = skb->data; - } else + else rx_buff = kmalloc(PKT_BUF_SZ, GFP_DMA | gfp); if (rx_buff == NULL) lp->rx_ring[i].base = 0;