From patchwork Wed Jul 4 10:33:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 168947 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 393D72C0201 for ; Wed, 4 Jul 2012 20:34:13 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933489Ab2GDKeL (ORCPT ); Wed, 4 Jul 2012 06:34:11 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:41698 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757010Ab2GDKeJ (ORCPT ); Wed, 4 Jul 2012 06:34:09 -0400 Received: by werb14 with SMTP id b14so4261106wer.19 for ; Wed, 04 Jul 2012 03:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer; bh=y+0WS73adTSYp6kKsbkp/MxbpIY8XAq6M70q+AiR5u0=; b=RQJfLjjf6QmYvhSAb1YN6lSe/wpZRgbLuke1bfxpcuQ6Tza2mAcotnsHjy1SDAFxgV 3LFtqi4cpqOQ1KePhBROlzgKwDdi+MWfntP0loesPgOaYMVjvH1vFMG7/MGHVuzNIXol uCMohC/x/WEDykX6VDyxVsFdRADWgRpHP/bGqjGAKHY6c5UNt+6hSdRrvkIXmblXPqGo 2ic6fFN6PxA+KgWiXl1DCHLNBy8O0XEzMTrsxZiSiWgW465yOaZwKLresGgfv9HQaLB1 Mx8I5dr62gfsDTFl/vNu+xEvUME6oSIg5mn7YQBfUIgpMCUZmUbTpyVOQ8zTvlJ7bkN1 74vw== Received: by 10.180.100.136 with SMTP id ey8mr4848658wib.15.1341398048351; Wed, 04 Jul 2012 03:34:08 -0700 (PDT) Received: from macbook.be.48ers.dk ([91.183.168.164]) by mx.google.com with ESMTPS id q6sm36757029wiy.0.2012.07.04.03.34.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 Jul 2012 03:34:07 -0700 (PDT) Received: by macbook.be.48ers.dk (Postfix, from userid 1000) id 027ECC3B49; Wed, 4 Jul 2012 12:34:05 +0200 (CEST) From: Peter Korsgaard To: netdev@vger.kernel.org, david.daney@cavium.com, davem@davemloft.net Cc: Peter Korsgaard Subject: [PATCH] bcm87xx: disable autonegotiation by default Date: Wed, 4 Jul 2012 12:33:57 +0200 Message-Id: <1341398037-7591-1-git-send-email-jacmet@sunsite.dk> X-Mailer: git-send-email 1.7.10 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The bcm87xx phys don't support autonegotiation, so don't use it by default, as otherwise phy_state_machine() will try to enable it (using c22 requests, which also don't make any sense for the bcm78xx). Signed-off-by: Peter Korsgaard --- Tested on a bcm8707, which uses the same id as 8727 drivers/net/phy/bcm87xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c index f5f0562..9a90dcf 100644 --- a/drivers/net/phy/bcm87xx.c +++ b/drivers/net/phy/bcm87xx.c @@ -89,6 +89,7 @@ static int bcm87xx_config_init(struct phy_device *phydev) phydev->supported = SUPPORTED_10000baseR_FEC; phydev->advertising = ADVERTISED_10000baseR_FEC; phydev->state = PHY_NOLINK; + phydev->autoneg = AUTONEG_DISABLE; bcm87xx_of_reg_init(phydev);