From patchwork Thu Jun 21 09:19:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yevgeny Petrilin X-Patchwork-Id: 166273 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 306D9B6FA7 for ; Thu, 21 Jun 2012 19:19:50 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932301Ab2FUJTr (ORCPT ); Thu, 21 Jun 2012 05:19:47 -0400 Received: from eu1sys200aog110.obsmtp.com ([207.126.144.129]:60409 "HELO eu1sys200aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932366Ab2FUJTp (ORCPT ); Thu, 21 Jun 2012 05:19:45 -0400 Received: from mtlsws123.lab.mtl.com ([82.166.227.17]) (using TLSv1) by eu1sys200aob110.postini.com ([207.126.147.11]) with SMTP ID DSNKT+LnLUTX6LMgmLwPnefptOxoxUnTRRh5@postini.com; Thu, 21 Jun 2012 09:19:44 UTC Received: from r-vnc07.lab.mtl.com (r-vnc07.lab.mtl.com [10.208.0.119]) by mtlsws123.lab.mtl.com (8.13.8/8.13.8) with ESMTP id q5L9JI80011170; Thu, 21 Jun 2012 12:19:37 +0300 From: Yevgeny Petrilin To: davem@davemloft.net Cc: netdev@vger.kernel.org, Yevgeny Petrilin Subject: [PATCH 1/4] net/mlx4_en: Set correct port parameters during device initialization Date: Thu, 21 Jun 2012 12:19:14 +0300 Message-Id: <1340270358-19504-2-git-send-email-yevgenyp@mellanox.co.il> X-Mailer: git-send-email 1.7.8.2 In-Reply-To: <1340270358-19504-1-git-send-email-yevgenyp@mellanox.co.il> References: <1340270358-19504-1-git-send-email-yevgenyp@mellanox.co.il> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set valid port parameters: MTU and flow control configuration when configuring the port during HW device initialization, prior to the net device open() being called. Using invalid parameters (such as all zeros) could lead to bad firmware behavior. Signed-off-by: Yevgeny Petrilin --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index 926d8aa..a80280e 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -1204,9 +1204,11 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, en_warn(priv, "Using %d RX rings\n", prof->rx_ring_num); /* Configure port */ + mlx4_en_calc_rx_buf(dev); err = mlx4_SET_PORT_general(mdev->dev, priv->port, - MLX4_EN_MIN_MTU, - 0, 0, 0, 0); + priv->rx_skb_size + ETH_FCS_LEN, + prof->tx_pause, prof->tx_ppp, + prof->rx_pause, prof->rx_ppp); if (err) { en_err(priv, "Failed setting port general configurations " "for port %d, with error %d\n", priv->port, err);