From patchwork Tue Jun 12 01:19:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Lei X-Patchwork-Id: 164297 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43090B6FC2 for ; Tue, 12 Jun 2012 11:20:20 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166Ab2FLBUP (ORCPT ); Mon, 11 Jun 2012 21:20:15 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:61786 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116Ab2FLBUL (ORCPT ); Mon, 11 Jun 2012 21:20:11 -0400 Received: by pbbrp8 with SMTP id rp8so59162pbb.19 for ; Mon, 11 Jun 2012 18:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=uYyK7VzH3o2ksJ6NlNdBjnN5iHZlrgtPaRhcCVV3ZGc=; b=JCtd8CDub9m7mLoHhfYO834niqjFByTRluEIFBj0IRUoK0HuAwJQzrWWn86nchURrV lJ1VaqcwFyj5vC5QOzMiYQqbLIrNoQPqlyNjGSyDIoN+NHqFFHJKDJH1NRr5xLfak4Lx DpLud+JyTmQ4w8wozOximjm1CSrPZFBhXugaMZY4D3mcoLEPDpf0f8LjgvCqANkmQ3Oh 5Y3Q/Kit7AZcpQjitn+t4ivd+x2eUaAU038xdg6LUUGWRHXjVU3nGj/MRWKtvgaRN2Cq KqJiChkLv2rzPsYyt6TbCokl7WLQYzxWm1f445twWfLwABd4GW7LepbGwc4mnZu6ed+M Nxtw== Received: by 10.68.201.9 with SMTP id jw9mr32409589pbc.28.1339464010506; Mon, 11 Jun 2012 18:20:10 -0700 (PDT) Received: from localhost ([183.37.205.112]) by mx.google.com with ESMTPS id qn1sm118876pbc.9.2012.06.11.18.20.06 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Jun 2012 18:20:09 -0700 (PDT) From: Ming Lei To: "David S. Miller" , Greg Kroah-Hartman Cc: Oliver Neukum , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Ming Lei Subject: [PATCH 1/7] usbnet: remove usb_get/put_dev in .probe and .disconnect Date: Tue, 12 Jun 2012 09:19:39 +0800 Message-Id: <1339463985-9006-2-git-send-email-tom.leiming@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1339463985-9006-1-git-send-email-tom.leiming@gmail.com> References: <1339463985-9006-1-git-send-email-tom.leiming@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org usb_device is parent device of usb_interface in the view of driver model, so its reference count is always held during .probe/.disconnect of usb_interface instance. This patch just removes the unnecessay usb_get/put_dev. Signed-off-by: Ming Lei --- drivers/net/usb/usbnet.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 9f58330..022c1e7 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1307,7 +1307,6 @@ void usbnet_disconnect (struct usb_interface *intf) usb_free_urb(dev->interrupt); free_netdev(net); - usb_put_dev (xdev); } EXPORT_SYMBOL_GPL(usbnet_disconnect); @@ -1363,8 +1362,6 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) xdev = interface_to_usbdev (udev); interface = udev->cur_altsetting; - usb_get_dev (xdev); - status = -ENOMEM; // set up our own records @@ -1493,7 +1490,6 @@ out3: out1: free_netdev(net); out: - usb_put_dev(xdev); return status; } EXPORT_SYMBOL_GPL(usbnet_probe);