From patchwork Tue Apr 24 23:13:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Wilczynski X-Patchwork-Id: 154770 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 76C8BB6FE2 for ; Wed, 25 Apr 2012 09:14:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037Ab2DXXN5 (ORCPT ); Tue, 24 Apr 2012 19:13:57 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:41084 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900Ab2DXXN4 (ORCPT ); Tue, 24 Apr 2012 19:13:56 -0400 Received: by wibhj6 with SMTP id hj6so4410296wib.1 for ; Tue, 24 Apr 2012 16:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=5acYlVQ56GpvO0gNHsFMP1V+410YWwYBqilzLhJyxSg=; b=KdYLcXDf8NcMYrPtvxdkyc/c0hyppn0VbElhzflCF5OrHVzUxIxWMKx46ZDpAQR1y8 wpqdJhfeahmZwYE6wc7bFxhVVkmVkjKK0eChchzWXwsD2hDfXI7LCu5vGSnZcXTuH266 1uUhtCBhY6jmgFQR7tG/vAWK2gs9E5Hgyafr9DQMGjMUQMHnO1jOSGj2FBHGdXleXqxk 66tfvA/Adoiy42ElAe1BbvPLDCG4/ThzUIUYyTV5GsWvc2EmK0wHgDgm0+bcklZWxh28 cgPtYb5/2Yia/MpvZQ1U4JS3IC8e8JnzSZ67gGTeCeBNPRMSQXPQuRxQ2CKXeUycSTJs b52w== Received: by 10.180.105.194 with SMTP id go2mr875989wib.22.1335309234732; Tue, 24 Apr 2012 16:13:54 -0700 (PDT) Received: from localhost.localdomain ([84.45.95.241]) by mx.google.com with ESMTPS id gd4sm51731534wib.6.2012.04.24.16.13.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Apr 2012 16:13:53 -0700 (PDT) From: Krzysztof Wilczynski To: Karsten Keil Cc: Greg Kroah-Hartman , Simon Horman , Jiri Kosina , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mISDN: Ignore return value of driver_for_each_device in function hfcpci_softirq. Date: Wed, 25 Apr 2012 00:13:50 +0100 Message-Id: <1335309230-23428-1-git-send-email-krzysztof.wilczynski@linux.com> X-Mailer: git-send-email 1.7.2.5 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Function hfcpci_softirq uses driver_for_each_device to call _hfcpci_softirq for each device. Given that _hfcpci_softirq always returns 0, we collect this return value and simply do nothing with it. This is purely to address the following warning during compilation time: drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’: drivers/isdn/hardware/mISDN/hfcpci.c:2319: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result Similar approach was used in function cx18_alsa_exit from "cx18-alsa-main.c". Signed-off-by: Krzysztof Wilczynski --- drivers/isdn/hardware/mISDN/hfcpci.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c index e2c83a2..f0d0180 100644 --- a/drivers/isdn/hardware/mISDN/hfcpci.c +++ b/drivers/isdn/hardware/mISDN/hfcpci.c @@ -2316,8 +2316,11 @@ _hfcpci_softirq(struct device *dev, void *arg) static void hfcpci_softirq(void *arg) { - (void) driver_for_each_device(&hfc_driver.driver, NULL, arg, - _hfcpci_softirq); + int ret; + + /* Collect return value, but do not use it; suppress GCC warning ... */ + ret = driver_for_each_device(&hfc_driver.driver, NULL, arg, + _hfcpci_softirq); /* if next event would be in the past ... */ if ((s32)(hfc_jiffies + tics - jiffies) <= 0)