From patchwork Thu Apr 12 18:27:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sjur.brandeland@stericsson.com X-Patchwork-Id: 152160 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 052C0B70BA for ; Fri, 13 Apr 2012 04:27:55 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100Ab2DLS1n (ORCPT ); Thu, 12 Apr 2012 14:27:43 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:49163 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934175Ab2DLS1l (ORCPT ); Thu, 12 Apr 2012 14:27:41 -0400 Received: by lahj13 with SMTP id j13so1796038lah.19 for ; Thu, 12 Apr 2012 11:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=JQBykn40xqw2xkjCiBhCl7M1qKJkqg4P4RKJsRDly/s=; b=trv9cKuy2kaG/VyE+9DZMpIWpsThVoY/JKDF9sm09RdsE0u26FiHMQpZGCw50J/TLx 66XODUFln/iE9qndEiClgnFeZWVUPTDkzpIqvEGf25snu6E6p+6M4WIfQ7emkrsqUVCd uA890acOVvm8ilmOk9pQV3axJAVCJX7XOLohtEM4YgHsbgTgf+tj8kr/JVkGL56KCa6Z XPrPdrZRbJOr8MVYBSBiKLe9EsL9UwmMr4zhmR67ithEFvfUqNGiIodUIq7J+4/4jvMV ks2OfKvkIF3QFN+vYbqLVOqBGSLN+a7OBUXyXbnGd9NlAQyuzBXzEL4TRJTYZ6tkD++e JGww== Received: by 10.152.127.163 with SMTP id nh3mr3108838lab.15.1334255260064; Thu, 12 Apr 2012 11:27:40 -0700 (PDT) Received: from localhost.localdomain ([212.4.57.94]) by mx.google.com with ESMTPS id c3sm8661103lbg.6.2012.04.12.11.27.38 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Apr 2012 11:27:39 -0700 (PDT) From: =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= To: netdev@vger.kernel.org, davem@davemloft.net Cc: sjurbren@gmail.com, =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= Subject: [PATCH net-next 3/4] caif-hsi: Remove stop/start of queue. Date: Thu, 12 Apr 2012 20:27:26 +0200 Message-Id: <1334255247-3372-4-git-send-email-sjur.brandeland@stericsson.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1334255247-3372-1-git-send-email-sjur.brandeland@stericsson.com> References: <1334255247-3372-1-git-send-email-sjur.brandeland@stericsson.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org CAIF HSI is currently a virtual device. Stopping/starting the queues is wrong on a virtual device. Signed-off-by: Sjur Brændeland --- drivers/net/caif/caif_hsi.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c index 9849a23..4253991 100644 --- a/drivers/net/caif/caif_hsi.c +++ b/drivers/net/caif/caif_hsi.c @@ -1129,15 +1129,11 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev) static int cfhsi_open(struct net_device *dev) { - netif_wake_queue(dev); - return 0; } static int cfhsi_close(struct net_device *dev) { - netif_stop_queue(dev); - return 0; } @@ -1319,9 +1315,6 @@ int cfhsi_probe(struct platform_device *pdev) __func__, res); goto err_net_reg; } - - netif_stop_queue(ndev); - return res; err_net_reg: @@ -1344,9 +1337,6 @@ static void cfhsi_shutdown(struct cfhsi *cfhsi) { u8 *tx_buf, *rx_buf, *flip_buf; - /* Stop TXing */ - netif_tx_stop_all_queues(cfhsi->ndev); - /* going to shutdown driver */ set_bit(CFHSI_SHUTDOWN, &cfhsi->bits);