From patchwork Mon Apr 9 05:59:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 151403 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2702EB703A for ; Mon, 9 Apr 2012 16:01:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871Ab2DIGBw (ORCPT ); Mon, 9 Apr 2012 02:01:52 -0400 Received: from mail-pz0-f52.google.com ([209.85.210.52]:65249 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448Ab2DIGBv (ORCPT ); Mon, 9 Apr 2012 02:01:51 -0400 Received: by dake40 with SMTP id e40so4867143dak.11 for ; Sun, 08 Apr 2012 23:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=P0WcfG+Nd81/8R5gSmOvCQJeG8aMsE2p8NhoyZ4f/Xw=; b=D4c8wzNYU6hoMVIuOhT+o2e0yU/WJ/Ii/N3xxVe6vYFKtW9t8SQlgIMv01bjLmpa9p kxzfMfhcjD9QQ1ih/rBgVAOOFGbcyIrO3GfOl855yJdavLCUOrPNjiALLIQGhwJtZBWz r0KwbgBnLfOT/gnT4GqX9MWdvs2D6P3LqMyYUuWC9nAHV1eUs0y2SAGtawiA5mSSjO0I Kd2yUBIQWp9crYmudmoHfZLpYtbIbb3NTTzlJpN2QY6D5G1a56qwLu9wZHaGQy8d0/4M s0sOoOYaO7634/URkfdLV55+Ibpu2shjfTI1ivCUBJg6TdwuqSxqqGTYFcOiP+1gQhhO On5w== Received: by 10.68.234.37 with SMTP id ub5mr3081237pbc.103.1333951310677; Sun, 08 Apr 2012 23:01:50 -0700 (PDT) Received: from localhost.localdomain ([64.103.156.72]) by mx.google.com with ESMTPS id t5sm13985607pbm.64.2012.04.08.23.01.43 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 Apr 2012 23:01:50 -0700 (PDT) From: santosh nayak To: anirban.chakraborty@qlogic.com, rajesh.borundia@qlogic.com Cc: sony.chacko@qlogic.com, linux-driver@qlogic.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 1/2] qlcnic: Add default swtich case in 'qlcnic_can_start_firmware()' Date: Mon, 9 Apr 2012 11:29:47 +0530 Message-Id: <1333951187-4395-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak QLCRD32() may return bad state. Its good to have default switch case: 1. to avoid unexpected system behaviour. 2. to avoid extra computation thats happening after switch case. Signed-off-by: Santosh Nayak --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 75c32e8..d30b9b8 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -2787,6 +2787,11 @@ qlcnic_can_start_firmware(struct qlcnic_adapter *adapter) case QLCNIC_DEV_INITIALIZING: case QLCNIC_DEV_QUISCENT: break; + + default: + dev_err(&adapter->pdev->dev, "Invalid state\n"); + qlcnic_api_unlock(adapter); + return -EINVAL; } qlcnic_api_unlock(adapter);