From patchwork Tue Apr 3 08:47:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 150341 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 33C0EB6FDB for ; Tue, 3 Apr 2012 18:47:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630Ab2DCIrB (ORCPT ); Tue, 3 Apr 2012 04:47:01 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44907 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571Ab2DCIq7 (ORCPT ); Tue, 3 Apr 2012 04:46:59 -0400 Received: by mail-pb0-f46.google.com with SMTP id un15so5350239pbc.19 for ; Tue, 03 Apr 2012 01:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=+qh7/Ge2gBiuVfZjhTmGaPkl1juoC6lXBMpcBNPiM8o=; b=t+EK4VAM84Jlu+ssOlryScH9CoCiju+/3uvK4AMgP2p8WiFkWNHcmHcCYKwxeHCDtL e2ZIF+QNnBv2gBGarPoK8CXZh//5jcr9X1HRz1H8nDgvgPqzE/vG/nif17o7MYRXAjgd VKcBSgd2ils/y976ge3cjx/0Kzc4+BYdmE4wx0ABOTRqT9ddez7GdgPcAGLAJ0JzNnTE YGCRq6I82PKVAc0owOXgTpkpHinWLKatNiLNYGYrYb1io/pL5VnXG9WCWG9x63lCkZH1 DovvD9W/ora6b6ZvIxHbh9g+Lw+IkkbMffGFkwfNabEBlo07BgIpVNepnadInQQ1peBw QsvQ== Received: by 10.68.216.234 with SMTP id ot10mr27754689pbc.107.1333442818601; Tue, 03 Apr 2012 01:46:58 -0700 (PDT) Received: from localhost.localdomain (p3031-adsao03yokonib2-acca.kanagawa.ocn.ne.jp. [219.165.63.31]) by mx.google.com with ESMTPS id u5sm15850112pbu.76.2012.04.03.01.46.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Apr 2012 01:46:57 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Akinobu Mita , Dmitry Kozlov , netdev@vger.kernel.org Subject: [PATCH 4/4] ppp: use for_each_set_bit_from Date: Tue, 3 Apr 2012 17:47:16 +0900 Message-Id: <1333442836-9947-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1333442836-9947-1-git-send-email-akinobu.mita@gmail.com> References: <1333442836-9947-1-git-send-email-akinobu.mita@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use for_each_set_bit_from to iterate over all the set bit in a memory region. Signed-off-by: Akinobu Mita Cc: Dmitry Kozlov Cc: netdev@vger.kernel.org --- drivers/net/ppp/pptp.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index 885dbdd..72b50f5 100644 --- a/drivers/net/ppp/pptp.c +++ b/drivers/net/ppp/pptp.c @@ -116,8 +116,8 @@ static int lookup_chan_dst(u16 call_id, __be32 d_addr) int i; rcu_read_lock(); - for (i = find_next_bit(callid_bitmap, MAX_CALLID, 1); i < MAX_CALLID; - i = find_next_bit(callid_bitmap, MAX_CALLID, i + 1)) { + i = 1; + for_each_set_bit_from(i, callid_bitmap, MAX_CALLID) { sock = rcu_dereference(callid_sock[i]); if (!sock) continue;