From patchwork Mon Mar 26 19:01:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 148814 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EED9BB6F98 for ; Tue, 27 Mar 2012 06:01:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933401Ab2CZTBo (ORCPT ); Mon, 26 Mar 2012 15:01:44 -0400 Received: from zimbra.vipri.net ([89.207.250.15]:42376 "EHLO zimbra.vipri.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933090Ab2CZTBm (ORCPT ); Mon, 26 Mar 2012 15:01:42 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.vipri.net (Postfix) with ESMTP id 6D1D0100026F; Mon, 26 Mar 2012 21:01:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.vipri.net Received: from zimbra.vipri.net ([127.0.0.1]) by localhost (zimbra.vipri.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yX2oQmpq1pUG; Mon, 26 Mar 2012 21:01:38 +0200 (CEST) Received: from phil.computerman.de (host-089-207-255-234.vipri.net [89.207.255.234]) by zimbra.vipri.net (Postfix) with ESMTPSA id 103E81000244; Mon, 26 Mar 2012 21:01:38 +0200 (CEST) From: Phil Sutter To: David Miller Cc: netdev@vger.kernel.org, inaky.perez-gonzalez@intel.com, Ben Hutchings Subject: [PATCHv2 1/2] wimax: i2400m - prevent a possible kernel bug due to missing fw_name string Date: Mon, 26 Mar 2012 21:01:30 +0200 Message-Id: <1332788491-21530-1-git-send-email-phil.sutter@viprinet.com> X-Mailer: git-send-email 1.7.8.5 In-Reply-To: <1332773830.3500.88.camel@deadeye> References: <1332773830.3500.88.camel@deadeye> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This happened on a machine with a custom hotplug script calling nameif, probably due to slow firmware loading. At the time nameif uses ethtool to gather interface information, i2400m->fw_name is zero and so a null pointer dereference occurs from within i2400m_get_drvinfo(). Signed-off-by: Phil Sutter --- drivers/net/wimax/i2400m/netdev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wimax/i2400m/netdev.c b/drivers/net/wimax/i2400m/netdev.c index 63e4b70..1d76ae8 100644 --- a/drivers/net/wimax/i2400m/netdev.c +++ b/drivers/net/wimax/i2400m/netdev.c @@ -597,7 +597,8 @@ static void i2400m_get_drvinfo(struct net_device *net_dev, struct i2400m *i2400m = net_dev_to_i2400m(net_dev); strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver) - 1); - strncpy(info->fw_version, i2400m->fw_name, sizeof(info->fw_version) - 1); + strncpy(info->fw_version, + i2400m->fw_name ? : "", sizeof(info->fw_version) - 1); if (net_dev->dev.parent) strncpy(info->bus_info, dev_name(net_dev->dev.parent), sizeof(info->bus_info) - 1);