From patchwork Fri Mar 16 13:10:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 147202 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 188E1B6F98 for ; Sat, 17 Mar 2012 00:11:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755832Ab2CPNLj (ORCPT ); Fri, 16 Mar 2012 09:11:39 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33966 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838Ab2CPNLi (ORCPT ); Fri, 16 Mar 2012 09:11:38 -0400 Received: by pbcun15 with SMTP id un15so200200pbc.19 for ; Fri, 16 Mar 2012 06:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=jkXjLE3jXq/2tiqppUcist7KNfFaJclTDixvHS3WZiQ=; b=rFbHT9FVfG7NGfJYe1WcQR07dvZXbouCnoroPTc/M1CnRXn6jO4NE+KnOOD9h1t7cr mbMH+w8R/9iwxB4th4rw4AN+9ESZ6b7JWECdlDvCYCiuhBpfkCi8v1ucB2QvNHCNCp+k WqyQ+6dpMG68MnS05lmGUqN2eKhPMdC7XYnGFwpXsaDPNCjr0l3q6vUTv3OY/GqErvrT BKNrNl7mqs8g/FJ7TBbRaV2zqVM5aRDQS2jND+Dq52VzV/2LuEbv1knAq11yBJC29gjB oeD4J2S1k8butpQy9KS+QMZjBmGq0p4Bh85OqJbqNK9Hbyqq/B2ifSf7itq70hQ4aApV foqA== Received: by 10.68.226.170 with SMTP id rt10mr14663359pbc.117.1331903497502; Fri, 16 Mar 2012 06:11:37 -0700 (PDT) Received: from localhost.localdomain ([64.103.156.72]) by mx.google.com with ESMTPS id ko12sm4275103pbb.52.2012.03.16.06.11.33 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Mar 2012 06:11:36 -0700 (PDT) From: santosh nayak To: hjlipp@web.de Cc: tilman@imap.cc, isdn@linux-pingi.de, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails. Date: Fri, 16 Mar 2012 18:40:13 +0530 Message-Id: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak If locking attempt was interrupted by a signal then we should return -EINTR so that caller can take appropriate action. We have 3 callers: gigaset_probe(), gigaset_tty_open() and gigaset_probe(). Each caller tries to free allocated memory if lock fails. This is possible if we returns -EINTR. Signed-off-by: Santosh Nayak --- drivers/isdn/gigaset/common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index 7679270..2d10f3a 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -903,7 +903,7 @@ int gigaset_start(struct cardstate *cs) unsigned long flags; if (mutex_lock_interruptible(&cs->mutex)) - return 0; + return -EINTR; spin_lock_irqsave(&cs->lock, flags); cs->connected = 1;