From patchwork Tue Mar 13 10:58:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 146385 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48520B6F62 for ; Tue, 13 Mar 2012 21:56:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756382Ab2CMK4V (ORCPT ); Tue, 13 Mar 2012 06:56:21 -0400 Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:45816 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150Ab2CMK4U (ORCPT ); Tue, 13 Mar 2012 06:56:20 -0400 Received: from mail118-va3-R.bigfish.com (10.7.14.239) by VA3EHSOBE003.bigfish.com (10.7.40.23) with Microsoft SMTP Server id 14.1.225.23; Tue, 13 Mar 2012 10:56:18 +0000 Received: from mail118-va3 (localhost [127.0.0.1]) by mail118-va3-R.bigfish.com (Postfix) with ESMTP id 32D7A2C010E; Tue, 13 Mar 2012 10:56:19 +0000 (UTC) X-SpamScore: 3 X-BigFish: VS3(zzzz1202h1082kzz8275dhz2dh2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail118-va3 (localhost.localdomain [127.0.0.1]) by mail118-va3 (MessageSwitch) id 1331636177523506_4016; Tue, 13 Mar 2012 10:56:17 +0000 (UTC) Received: from VA3EHSMHS020.bigfish.com (unknown [10.7.14.247]) by mail118-va3.bigfish.com (Postfix) with ESMTP id 776A720004A; Tue, 13 Mar 2012 10:56:17 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS020.bigfish.com (10.7.99.30) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 13 Mar 2012 10:56:15 +0000 Received: from az33smr01.freescale.net (10.64.34.199) by 039-SN1MMR1-003.039d.mgd.msft.net (10.84.1.16) with Microsoft SMTP Server id 14.1.355.3; Tue, 13 Mar 2012 05:56:14 -0500 Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id q2DAu926025954; Tue, 13 Mar 2012 05:56:10 -0500 (CDT) From: Dong Aisheng To: , , CC: , , , Subject: [PATCH 1/1] net: phylib: add error checking if no phy found Date: Tue, 13 Mar 2012 18:58:22 +0800 Message-ID: <1331636302-18256-1-git-send-email-b29396@freescale.com> X-Mailer: git-send-email 1.7.0.4 MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dong Aisheng Signed-off-by: Dong Aisheng --- drivers/net/phy/mdio_bus.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 88cc5db..d8e044d 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -101,6 +101,7 @@ static struct class mdio_bus_class = { int mdiobus_register(struct mii_bus *bus) { int i, err; + u32 phynum = 0; if (NULL == bus || NULL == bus->name || NULL == bus->read || @@ -134,12 +135,20 @@ int mdiobus_register(struct mii_bus *bus) if (IS_ERR(phydev)) { err = PTR_ERR(phydev); goto error; + } else if (phydev != NULL) { + phynum++; } } } + if (!phynum) { + err = -ENODEV; + printk(KERN_ERR "%s: no phys found\n", bus->name); + goto error; + } + bus->state = MDIOBUS_REGISTERED; - pr_info("%s: probed\n", bus->name); + pr_info("%s: %d phys probed\n", bus->name, phynum); return 0; error: