From patchwork Fri Feb 24 16:57:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 142948 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E405CB6F62 for ; Sat, 25 Feb 2012 03:58:33 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757905Ab2BXQ6P (ORCPT ); Fri, 24 Feb 2012 11:58:15 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:55978 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984Ab2BXQ6O (ORCPT ); Fri, 24 Feb 2012 11:58:14 -0500 Received: by daed14 with SMTP id d14so2684615dae.19 for ; Fri, 24 Feb 2012 08:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=rs9A5y2KEnlT3sgfe6JEK8bnVcddAdk17bKoI5DVCKk=; b=VvUVWEyntUOlt6JGdO4On6hgg7a8QMKObiST7HcmlCSQ1f0CvGMeCcD5OW1MoVBH6h dkFGn41CCwQ6CzEY4iw9BkQvFJrWZkdchGXD1oQYzPJ/JqJTBzTs317tTP6jDD/R+XQp f2riaOfvBd7RDPzO7gOpkqO1n9CXPkIVkeTtE= Received: by 10.68.73.97 with SMTP id k1mr8205188pbv.61.1330102694132; Fri, 24 Feb 2012 08:58:14 -0800 (PST) Received: from localhost.localdomain (72-163-216-217.cisco.com. [72.163.216.217]) by mx.google.com with ESMTPS id s10sm3685933pbq.13.2012.02.24.08.58.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 08:58:13 -0800 (PST) From: santosh nayak To: benve@cisco.com Cc: roprabhu@cisco.com, neepatel@cisco.com, nistrive@cisco.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 2/2] enic: Silence Sparse Warning: "dubious: x | !y" Date: Fri, 24 Feb 2012 22:27:34 +0530 Message-Id: <1330102654-2474-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak Sparse is giving the following warning: "warning: dubious: x | !y" "enic_are_pp_different" is static and expected to return true or false. Logical or is indended here. With logical or, in best case, execution will be faster because if leftmost operand is true then no need to check other operands. Signed-off-by: Santosh Nayak --- drivers/net/ethernet/cisco/enic/enic_pp.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c index dafea1e..3a6de22 100644 --- a/drivers/net/ethernet/cisco/enic/enic_pp.c +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c @@ -159,10 +159,10 @@ static int enic_unset_port_profile(struct enic *enic, int vf) static int enic_are_pp_different(struct enic_port_profile *pp1, struct enic_port_profile *pp2) { - return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid, - pp2->instance_uuid, PORT_UUID_MAX) | - !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) | - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); + return strcmp(pp1->name, pp2->name) || !!memcmp(pp1->instance_uuid, + pp2->instance_uuid, PORT_UUID_MAX) || + !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) || + !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); } static int enic_pp_preassociate(struct enic *enic, int vf,