From patchwork Fri Dec 9 13:47:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Lothar_Wa=C3=9Fmann?= X-Patchwork-Id: 130380 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5264A1007D7 for ; Sat, 10 Dec 2011 00:47:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730Ab1LINri (ORCPT ); Fri, 9 Dec 2011 08:47:38 -0500 Received: from mail.karo-electronics.de ([81.173.242.67]:65432 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693Ab1LINrh (ORCPT ); Fri, 9 Dec 2011 08:47:37 -0500 From: =?utf-8?q?Lothar=20Wa=C3=9Fmann?= To: Wolfgang Grandegger Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Lothar=20Wa=C3=9Fmann?= Subject: [PATCH] flexcan: Acknowledge all interrupt sources in the IRQ handler Date: Fri, 9 Dec 2011 14:47:34 +0100 Message-Id: <1323438454-6816-1-git-send-email-LW@KARO-electronics.de> X-Mailer: git-send-email 1.5.6.5 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Otherwise the handler will get stuck in an endless IRQ loop when an interrupt condition occurs that is not being acked (e.g. TWRN) Signed-off-by: Lothar Waßmann --- drivers/net/can/flexcan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index e023379..ea8f04d 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -577,7 +577,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) reg_iflag1 = flexcan_read(®s->iflag1); reg_esr = flexcan_read(®s->esr); - flexcan_write(FLEXCAN_ESR_ERR_INT, ®s->esr); /* ACK err IRQ */ + flexcan_write(reg_esr, ®s->esr); /* ACK all IRQs */ /* * schedule NAPI in case of: