From patchwork Tue Dec 6 22:15:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sjur.brandeland@stericsson.com X-Patchwork-Id: 129830 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1B1DA1007D6 for ; Wed, 7 Dec 2011 09:16:03 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309Ab1LFWPz (ORCPT ); Tue, 6 Dec 2011 17:15:55 -0500 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:62580 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886Ab1LFWPz (ORCPT ); Tue, 6 Dec 2011 17:15:55 -0500 Received: by lagp5 with SMTP id p5so1832667lag.19 for ; Tue, 06 Dec 2011 14:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=0OzuRUoF2MGgq6Zo5X9LnJafHW6/qC+XlJJ4cn3lzho=; b=bwlPxhksZ20KVmNe0oJ2xzukgFQHydGk9jJiV2CoUvn3NYrMEttO6CO6Ny71Hz/7ts fYdH6Del/cPLwJi6IVVnlhZLgaPjDo6dcWc0Td4HlhbqWEMjT1FwlmdPNolvx4NcbskS drQFnAiDzzIdi3KyFC28Kwnh/GTFUm0KpGfjU= Received: by 10.152.104.103 with SMTP id gd7mr2674581lab.34.1323209753775; Tue, 06 Dec 2011 14:15:53 -0800 (PST) Received: from localhost.localdomain (cm-188.126.199.228.customer.telag.net. [188.126.199.228]) by mx.google.com with ESMTPS id ni5sm22208120lab.3.2011.12.06.14.15.51 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Dec 2011 14:15:52 -0800 (PST) From: =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= To: netdev@vger.kernel.org, David Miller Cc: Christian Auby , =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= Subject: [PATCHv2 net-next 1/4] caif-hsi: Remove wake line modification when flushing FIFO Date: Tue, 6 Dec 2011 23:15:41 +0100 Message-Id: <1323209744-9718-1-git-send-email-sjur.brandeland@stericsson.com> X-Mailer: git-send-email 1.7.0.4 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Christian Auby Raising wake before flushing FIFO and lowering it after caused a spike on AC wake that were sometimes detected and acted upon by the modem. Fixed this by remove wake line modification when flushing FIFO. Signed-off-by: Sjur Brændeland --- drivers/net/caif/caif_hsi.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c index 0733525..a85b29e 100644 --- a/drivers/net/caif/caif_hsi.c +++ b/drivers/net/caif/caif_hsi.c @@ -117,15 +117,6 @@ static int cfhsi_flush_fifo(struct cfhsi *cfhsi) dev_dbg(&cfhsi->ndev->dev, "%s.\n", __func__); - - ret = cfhsi->dev->cfhsi_wake_up(cfhsi->dev); - if (ret) { - dev_warn(&cfhsi->ndev->dev, - "%s: can't wake up HSI interface: %d.\n", - __func__, ret); - return ret; - } - do { ret = cfhsi->dev->cfhsi_fifo_occupancy(cfhsi->dev, &fifo_occupancy); @@ -168,8 +159,6 @@ static int cfhsi_flush_fifo(struct cfhsi *cfhsi) } } while (1); - cfhsi->dev->cfhsi_wake_down(cfhsi->dev); - return ret; }