From patchwork Wed Nov 30 23:02:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sjur.brandeland@stericsson.com X-Patchwork-Id: 128607 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 188A2B6F67 for ; Thu, 1 Dec 2011 10:02:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278Ab1K3XCt (ORCPT ); Wed, 30 Nov 2011 18:02:49 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:61062 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107Ab1K3XCs (ORCPT ); Wed, 30 Nov 2011 18:02:48 -0500 Received: by eaak14 with SMTP id k14so1346741eaa.19 for ; Wed, 30 Nov 2011 15:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ps9lrjdRxByFSE8KGE846mpibJMiR1HgOJpHw52WaC0=; b=cnzLLfs+fwE/DxqKKoFyDTE7EGmH2VHJLoPnj0Gki6izhD5CAusvmMZ5FbWYcKs+Oh UneV6rjbBmLkIptHJtL6GIJTT3RJMgtqcU3OTeS3IDQW63bnKrtKWjDRXbP4DtcgbNJQ 2DN7qJtc3nqij1onPHbgKygDTq+eJVqqGP4KM= Received: by 10.213.30.8 with SMTP id s8mr148589ebc.109.1322694167049; Wed, 30 Nov 2011 15:02:47 -0800 (PST) Received: from localhost.localdomain (125.80-203-142.nextgentel.com. [80.203.142.125]) by mx.google.com with ESMTPS id x12sm11194997eef.9.2011.11.30.15.02.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Nov 2011 15:02:46 -0800 (PST) From: =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= To: netdev@vger.kernel.org, David Miller Cc: =?UTF-8?q?Sjur=20Br=C3=A6ndeland?= Subject: [PATCH] caif: Remove unused attributes from struct cflayer Date: Thu, 1 Dec 2011 00:02:32 +0100 Message-Id: <1322694152-5422-1-git-send-email-sjur.brandeland@stericsson.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <20111130.170457.1002117290486935116.davem@davemloft.net> References: <20111130.170457.1002117290486935116.davem@davemloft.net> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Sjur Brændeland --- Hi Dave, >... >Looks like this code was always buggy, passing the index in the type parameter >and the type in the instance parameter. > Yes, you're right. The type and prio isn't used anyway, so let's just kill it off. Regards, Sjur include/net/caif/caif_layer.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/net/caif/caif_layer.h b/include/net/caif/caif_layer.h index 35bc788..0f3a391 100644 --- a/include/net/caif/caif_layer.h +++ b/include/net/caif/caif_layer.h @@ -121,9 +121,7 @@ enum caif_direction { * @transmit: Packet transmit funciton. * @ctrlcmd: Used for control signalling upwards in the stack. * @modemcmd: Used for control signaling downwards in the stack. - * @prio: Priority of this layer. * @id: The identity of this layer - * @type: The type of this layer * @name: Name of the layer. * * This structure defines the layered structure in CAIF. @@ -230,9 +228,7 @@ struct cflayer { */ int (*modemcmd) (struct cflayer *layr, enum caif_modemcmd ctrl); - unsigned short prio; unsigned int id; - unsigned int type; char name[CAIF_LAYER_NAME_SZ]; };