From patchwork Thu Oct 20 21:00:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Moffett X-Patchwork-Id: 120899 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6B913B7090 for ; Fri, 21 Oct 2011 08:14:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753411Ab1JTVN4 (ORCPT ); Thu, 20 Oct 2011 17:13:56 -0400 Received: from 26.241.167.70.in-addr.border.exmeritus.com ([70.167.241.26]:35680 "EHLO border.exmeritus.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753308Ab1JTVNZ (ORCPT ); Thu, 20 Oct 2011 17:13:25 -0400 Received: from ysera.exmeritus.com (firewall2.exmeritus.com [10.13.38.2]) by border.exmeritus.com (Postfix) with ESMTP id 02EA8AC09B; Thu, 20 Oct 2011 17:02:52 -0400 (EDT) From: Kyle Moffett To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Kyle Moffett , "David S. Miller" , Mike Frysinger , Sonic Zhang , Tobias Klauser , uclinux-dist-devel@blackfin.uclinux.org Subject: [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY Date: Thu, 20 Oct 2011 17:00:15 -0400 Message-Id: <1319144425-15547-9-git-send-email-Kyle.D.Moffett@boeing.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> References: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The PHY is already reset during driver probing, and this manual reset afterwards will wipe out board-specific PHY fixups and driver-specific phy->drv->config_init() register tweaks. Signed-off-by: Kyle Moffett Acked-by: Mike Frysinger Acked-by: Sonic Zhang --- drivers/net/bfin_mac.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 6c019e1..1427ec3 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@ -1402,7 +1402,6 @@ static int bfin_mac_open(struct net_device *dev) return ret; phy_start(lp->phydev); - phy_write(lp->phydev, MII_BMCR, BMCR_RESET); setup_system_regs(dev); setup_mac_addr(dev->dev_addr);