From patchwork Thu Oct 20 21:00:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Moffett X-Patchwork-Id: 120887 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 06B931007D2 for ; Fri, 21 Oct 2011 08:09:50 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627Ab1JTVIW (ORCPT ); Thu, 20 Oct 2011 17:08:22 -0400 Received: from 26.241.167.70.in-addr.border.exmeritus.com ([70.167.241.26]:35653 "EHLO border.exmeritus.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750878Ab1JTVIV (ORCPT ); Thu, 20 Oct 2011 17:08:21 -0400 X-Greylist: delayed 434 seconds by postgrey-1.27 at vger.kernel.org; Thu, 20 Oct 2011 17:08:20 EDT Received: from ysera.exmeritus.com (firewall2.exmeritus.com [10.13.38.2]) by border.exmeritus.com (Postfix) with ESMTP id A81D9AC083; Thu, 20 Oct 2011 17:01:50 -0400 (EDT) From: Kyle Moffett To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Kyle Moffett , Kristoffer Glembo Subject: [RFC PATCH 03/17] greth: Allow PHYs to override ->read_status Date: Thu, 20 Oct 2011 17:00:10 -0400 Message-Id: <1319144425-15547-4-git-send-email-Kyle.D.Moffett@boeing.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> References: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Instead of manually calling genphy_read_status(), the greth driver should call phy_read_status() to allow the PHY driver to override the read_status method with its own version. NOTE: Completely untested. Needs somebody with hardware to try it out. Signed-off-by: Kyle Moffett --- drivers/net/greth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/greth.c b/drivers/net/greth.c index 52a3900..e7f268f 100644 --- a/drivers/net/greth.c +++ b/drivers/net/greth.c @@ -1367,7 +1367,7 @@ static int greth_mdio_init(struct greth_private *greth) timeout = jiffies + 6*HZ; while (!phy_aneg_done(greth->phy) && time_before(jiffies, timeout)) { } - genphy_read_status(greth->phy); + phy_read_status(greth->phy); greth_link_change(greth->netdev); }