From patchwork Mon Apr 4 08:26:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 89598 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 30491B6FAD for ; Mon, 4 Apr 2011 18:26:50 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064Ab1DDI02 (ORCPT ); Mon, 4 Apr 2011 04:26:28 -0400 Received: from smtp.eu.citrix.com ([62.200.22.115]:47642 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754025Ab1DDI00 (ORCPT ); Mon, 4 Apr 2011 04:26:26 -0400 X-IronPort-AV: E=Sophos;i="4.63,296,1299456000"; d="scan'208";a="5117510" Received: from lonpmailmx01.citrite.net ([10.30.224.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 04 Apr 2011 08:26:25 +0000 Received: from [10.80.2.42] (10.80.2.42) by smtprelay.citrix.com (10.30.224.162) with Microsoft SMTP Server id 8.2.255.0; Mon, 4 Apr 2011 09:26:24 +0100 Subject: Re: Signed bit field; int have_hotplug_status_watch:1 From: Ian Campbell To: "Dr. David Alan Gilbert" CC: "virtualization@lists.linux-foundation.org" , Jeremy Fitzhardinge , "konrad.wilk@oracle.com" , netdev@vger.kernel.org, xen-devel In-Reply-To: <20110403213241.GA25913@gallifrey> References: <20110403213241.GA25913@gallifrey> Organization: Citrix Systems, Inc. Date: Mon, 4 Apr 2011 09:26:24 +0100 Message-ID: <1301905584.23887.49.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2011-04-03 at 22:32 +0100, Dr. David Alan Gilbert wrote: > Hi Ian, > I've been going through some sparse scans of the kernel and > it threw up: > > CHECK drivers/net/xen-netback/xenbus.c > drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield > > int have_hotplug_status_watch:1; > > from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85 > > It does look like that should be an unsigned (given it's assigned > 0 and 1) I agree. 8<---------------------------------- From 38fdb7199a0c3c5eb18ec27d2380e21116c97e29 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Mon, 4 Apr 2011 09:18:35 +0100 Subject: [PATCH] xen: netback: use unsigned type for one-bit bitfield. Fixes error from sparse: CHECK drivers/net/xen-netback/xenbus.c drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield int have_hotplug_status_watch:1; Reported-by: Dr. David Alan Gilbert Signed-off-by: Ian Campbell Cc: netdev@vger.kernel.org Cc: xen-devel@lists.xensource.com --- drivers/net/xen-netback/xenbus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 22b8c35..1ce729d 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -26,7 +26,7 @@ struct backend_info { struct xenvif *vif; enum xenbus_state frontend_state; struct xenbus_watch hotplug_status_watch; - int have_hotplug_status_watch:1; + u8 have_hotplug_status_watch:1; }; static int connect_rings(struct backend_info *);