From patchwork Sat Apr 2 00:07:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anirban Chakraborty X-Patchwork-Id: 89375 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 01C60B6FB0 for ; Sat, 2 Apr 2011 11:25:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756205Ab1DBAZR (ORCPT ); Fri, 1 Apr 2011 20:25:17 -0400 Received: from vpn.pathscale.com ([198.186.3.75]:34114 "HELO mx.mv.qlogic.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with SMTP id S1753995Ab1DBAZQ (ORCPT ); Fri, 1 Apr 2011 20:25:16 -0400 Received: from lnxdev-sm-001.mv.qlogic.com (dut6217.mv.qlogic.com [172.29.56.217]) by mx.mv.qlogic.com (Postfix) with ESMTP id 2544886429; Fri, 1 Apr 2011 17:12:03 -0700 (PDT) Received: by lnxdev-sm-001.mv.qlogic.com (Postfix, from userid 0) id B016314AC77; Fri, 1 Apr 2011 17:07:16 -0700 (PDT) From: anirban.chakraborty@qlogic.com To: netdev@vger.kernel.org Cc: davem@davemloft.com, Dept_NX_Linux_NIC_driver@qlogic.com, Sony Chacko Subject: [PATCH 2/9 net-next-2.6] qlcnic: Memory leak fix Date: Fri, 1 Apr 2011 17:07:09 -0700 Message-Id: <1301702836-3265-2-git-send-email-anirban.chakraborty@qlogic.com> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1301702836-3265-1-git-send-email-anirban.chakraborty@qlogic.com> References: <1301702836-3265-1-git-send-email-anirban.chakraborty@qlogic.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sony Chacko Fix a memory leak in error path of pci info. Signed-off-by: Sony Chacko QLCNIC_MAX_PCI_FUNC) - return QL_STATUS_INVALID_PARAM; + if (pfn > QLCNIC_MAX_PCI_FUNC) { + ret = QL_STATUS_INVALID_PARAM; + goto err_eswitch; + } adapter->npars[pfn].active = (u8)pci_info[i].active; adapter->npars[pfn].type = (u8)pci_info[i].type; adapter->npars[pfn].phy_port = (u8)pci_info[i].default_port;