From patchwork Sun Mar 13 16:54:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 86607 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 88719B6F7F for ; Mon, 14 Mar 2011 03:55:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104Ab1CMQyu (ORCPT ); Sun, 13 Mar 2011 12:54:50 -0400 Received: from mail.pripojeni.net ([217.66.174.14]:37555 "EHLO smtp.pripojeni.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754986Ab1CMQyr (ORCPT ); Sun, 13 Mar 2011 12:54:47 -0400 Received: from anemoi.localdomain ([217.66.174.142]) by smtp.pripojeni.net (Kerio Connect 7.1.3); Sun, 13 Mar 2011 17:54:35 +0100 From: Jiri Slaby To: davem@davemloft.net Cc: jirislaby@gmail.com, netdev@vger.kernel.org, gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= Subject: [PATCH 1/2] NET: cdc-phonet, fix stop-queue handling Date: Sun, 13 Mar 2011 17:54:30 +0100 Message-Id: <1300035271-8138-1-git-send-email-jslaby@suse.cz> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently there is a warning emitted by the cdc-phonet driver: WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0 [cdc_phonet]() Modules linked in: ... Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1 Call Trace: [] dump_trace+0x79/0x340 [] dump_stack+0x69/0x6f [] warn_slowpath_common+0x7b/0xc0 [] usbpn_probe+0x3bb/0x3f0 [cdc_phonet] ... ---[ end trace f5d3e02908603ab4 ]--- netif_stop_queue() cannot be called before register_netdev() So remove netif_stop_queue from the probe funtction to avoid that. Signed-off-by: Jiri Slaby Cc: Rémi Denis-Courmont Cc: David S. Miller Acked-by: Rémi Denis-Courmont --- drivers/net/usb/cdc-phonet.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c index 109751b..4cf4e36 100644 --- a/drivers/net/usb/cdc-phonet.c +++ b/drivers/net/usb/cdc-phonet.c @@ -392,7 +392,6 @@ int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *id) pnd = netdev_priv(dev); SET_NETDEV_DEV(dev, &intf->dev); - netif_stop_queue(dev); pnd->dev = dev; pnd->usb = usb_get_dev(usbdev);