From patchwork Tue Mar 1 09:31:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 84919 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E7570B7127 for ; Tue, 1 Mar 2011 20:31:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755943Ab1CAJbH (ORCPT ); Tue, 1 Mar 2011 04:31:07 -0500 Received: from smtp.citrix.com ([66.165.176.89]:9775 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517Ab1CAJbG (ORCPT ); Tue, 1 Mar 2011 04:31:06 -0500 X-IronPort-AV: E=Sophos;i="4.62,246,1297054800"; d="scan'208";a="12879167" Received: from ftlpmailmx02.citrite.net ([10.13.107.66]) by FTLPIPO01.CITRIX.COM with ESMTP/TLS/RC4-MD5; 01 Mar 2011 04:31:04 -0500 Received: from [10.80.2.42] (10.80.2.42) by FTLPMAILMX02.citrite.net (10.13.107.66) with Microsoft SMTP Server id 8.2.255.0; Tue, 1 Mar 2011 04:31:03 -0500 Subject: Re: [GIT/PATCH v3] xen network backend driver From: Ian Campbell To: Ben Hutchings CC: "netdev@vger.kernel.org" , xen-devel , Jeremy Fitzhardinge , Herbert Xu , Konrad Rzeszutek Wilk , Francois Romieu In-Reply-To: <1298919198.2569.14.camel@bwh-desktop> References: <1298914061.5034.996.camel@zakaz.uk.xensource.com> <1298919198.2569.14.camel@bwh-desktop> Organization: Citrix Systems, Inc. Date: Tue, 1 Mar 2011 09:31:01 +0000 Message-ID: <1298971861.5034.1951.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2011-02-28 at 18:53 +0000, Ben Hutchings wrote: > > > --- /dev/null > > +++ b/drivers/net/xen-netback/common.h > [...] > > + /* Statistics */ > > + int rx_gso_checksum_fixup; > > This should be defined as unsigned long (ideally it would be u64, but > that can't be updated atomically on 32-bit systems). Thanks, I'll address all your comments in netback shortly but first I guess xen-netfront also needs this: Ian. 8<----------------------------- From d04fc6794249e26a5e5ba5fabf1456bb0e0309d2 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Tue, 1 Mar 2011 09:29:45 +0000 Subject: [PATCH] xen: netfront: ethtool stats fields should be unsigned long Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be unsigned long as suggested by Ben Hutchings in <1298919198.2569.14.camel@bwh-desktop> Signed-off-by: Ian Campbell Cc: Ben Hutchings --- drivers/net/xen-netfront.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index a6ab973..df45323 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -122,7 +122,7 @@ struct netfront_info { struct mmu_update rx_mmu[NET_RX_RING_SIZE]; /* Statistics */ - int rx_gso_checksum_fixup; + unsigned long rx_gso_checksum_fixup; }; struct netfront_rx_info {