From patchwork Mon Feb 14 10:54:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasiliy Kulikov X-Patchwork-Id: 83063 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C6500B717E for ; Mon, 14 Feb 2011 21:54:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439Ab1BNKyf (ORCPT ); Mon, 14 Feb 2011 05:54:35 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:60639 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753032Ab1BNKyd (ORCPT ); Mon, 14 Feb 2011 05:54:33 -0500 Received: by fxm20 with SMTP id 20so5029530fxm.19 for ; Mon, 14 Feb 2011 02:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:to:cc:subject:date:message-id :x-mailer; bh=4dMd1Zn/OTSUa76Cs6NF/KHafwZtjC+Cq+jhDliCGn0=; b=ec4p4tgYCHRi5nuKh2hVfxJgDha4qwCupMHrls9LZ72AWhnhdy5mTLTApq+Cgq0LMp bgs4tLSy74CAAm4x+qKYNRPrX0lDp7LEjDKLHZV+KNtwu2y/ebzHSUwo74LIX5XevQC2 nmEWYDBtfKzUJUKJTOC+Jw9J27Ogg8ACQk5s0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=a3Be7sgGO/Nwb8hh778U2Bfwdxyf3QtV3Fb2YMZvqjUhGLTj8RXKI6pjvdy/U23+7H CuDw8IcbqsJ1bMM6fGzJd5DOHrJuKYS5DOtiYUnL0cDILYsGhDSfveuYoIrJWCfm6rvP pNlKnSQz7mNVEpMWcPR7icu5Janen1e9kl0gI= Received: by 10.223.96.66 with SMTP id g2mr4371758fan.61.1297680871434; Mon, 14 Feb 2011 02:54:31 -0800 (PST) Received: from localhost (ppp91-77-40-235.pppoe.mtu-net.ru [91.77.40.235]) by mx.google.com with ESMTPS id z1sm973641fau.21.2011.02.14.02.54.29 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Feb 2011 02:54:30 -0800 (PST) From: Vasiliy Kulikov To: linux-kernel@vger.kernel.org Cc: security@kernel.org, Marcel Holtmann , "Gustavo F. Padovan" , "David S. Miller" , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] bluethooth: sco: fix information leak to userspace Date: Mon, 14 Feb 2011 13:54:26 +0300 Message-Id: <1297680867-11551-1-git-send-email-segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org struct sco_conninfo has one padding byte in the end. Local variable cinfo of type sco_conninfo is copied to userspace with this uninizialized one byte, leading to old stack contents leak. Signed-off-by: Vasiliy Kulikov --- Compile tested. net/bluetooth/sco.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index 960c6d1..926ed39 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -703,6 +703,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user break; } + memset(&cinfo, 0, sizeof(cinfo)); cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle; memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);