| Message ID | 1297295776-3735-1-git-send-email-tomoya-linux@dsn.okisemi.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> Date: Thu, 10 Feb 2011 08:56:16 +0900 > Previous patch "[PATCH 1/3] pch_can: fix 800k comms issue" is wrong. > I should have modified tseg1_min not tseg2_min. > Please discard previous patch and use this patch. I can't "discard" the previous patch as it's already pushed upstream into my GIT tree and therefore cannot be reverted. You need to send a relative fix-up patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index c42e972..0534eed 100644 --- a/drivers/net/can/pch_can.c +++ b/drivers/net/can/pch_can.c @@ -185,7 +185,7 @@ struct pch_can_priv { static struct can_bittiming_const pch_can_bittiming_const = { .name = KBUILD_MODNAME, - .tseg1_min = 1, + .tseg1_min = 2, .tseg1_max = 16, .tseg2_min = 1, .tseg2_max = 8,
Previous patch "[PATCH 1/3] pch_can: fix 800k comms issue" is wrong. I should have modified tseg1_min not tseg2_min. Please discard previous patch and use this patch. Currently, 800k comms fails since prop_seg set zero. (EG20T PCH CAN register of prop_seg must be set more than 1) To prevent prop_seg set to zero, change tseg2_min 1 to 2. Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> --- drivers/net/can/pch_can.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)