diff mbox

net: add sysfs entry for device group

Message ID 1295876249-15634-1-git-send-email-ddvlad@rosedu.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Vlad Dogaru Jan. 24, 2011, 1:37 p.m. UTC
The group of a network device can be queried or changed from userspace
using sysfs.

For example, considering sysfs mounted in /sys, one can change the group
that interface lo belongs to:
	echo 1 > /sys/class/net/lo/group

Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
---
 net/core/net-sysfs.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

Comments

stephen hemminger Jan. 25, 2011, 4:41 a.m. UTC | #1
On Mon, 24 Jan 2011 15:37:29 +0200
Vlad Dogaru <ddvlad@rosedu.org> wrote:

> The group of a network device can be queried or changed from userspace
> using sysfs.
> 
> For example, considering sysfs mounted in /sys, one can change the group
> that interface lo belongs to:
> 	echo 1 > /sys/class/net/lo/group
> 
> Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>

Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Jan. 25, 2011, 7:23 a.m. UTC | #2
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 25 Jan 2011 14:41:06 +1000

> On Mon, 24 Jan 2011 15:37:29 +0200
> Vlad Dogaru <ddvlad@rosedu.org> wrote:
> 
>> The group of a network device can be queried or changed from userspace
>> using sysfs.
>> 
>> For example, considering sysfs mounted in /sys, one can change the group
>> that interface lo belongs to:
>> 	echo 1 > /sys/class/net/lo/group
>> 
>> Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
> 
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index e23c01b..b726131 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -295,6 +295,20 @@  static ssize_t show_ifalias(struct device *dev,
 	return ret;
 }
 
+NETDEVICE_SHOW(group, fmt_dec);
+
+static int change_group(struct net_device *net, unsigned long new_group)
+{
+	dev_set_group(net, (int) new_group);
+	return 0;
+}
+
+static ssize_t store_group(struct device *dev, struct device_attribute *attr,
+			 const char *buf, size_t len)
+{
+	return netdev_store(dev, attr, buf, len, change_group);
+}
+
 static struct device_attribute net_class_attributes[] = {
 	__ATTR(addr_assign_type, S_IRUGO, show_addr_assign_type, NULL),
 	__ATTR(addr_len, S_IRUGO, show_addr_len, NULL),
@@ -316,6 +330,7 @@  static struct device_attribute net_class_attributes[] = {
 	__ATTR(flags, S_IRUGO | S_IWUSR, show_flags, store_flags),
 	__ATTR(tx_queue_len, S_IRUGO | S_IWUSR, show_tx_queue_len,
 	       store_tx_queue_len),
+	__ATTR(group, S_IRUGO | S_IWUSR, show_group, store_group),
 	{}
 };