From patchwork Wed Jan 5 14:07:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 77597 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ACF73B711C for ; Thu, 6 Jan 2011 01:06:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355Ab1AEOGJ (ORCPT ); Wed, 5 Jan 2011 09:06:09 -0500 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:35981 "EHLO TX2EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026Ab1AEOGG (ORCPT ); Wed, 5 Jan 2011 09:06:06 -0500 Received: from mail163-tx2-R.bigfish.com (10.9.14.245) by TX2EHSOBE003.bigfish.com (10.9.40.23) with Microsoft SMTP Server id 14.1.225.8; Wed, 5 Jan 2011 14:06:05 +0000 Received: from mail163-tx2 (localhost.localdomain [127.0.0.1]) by mail163-tx2-R.bigfish.com (Postfix) with ESMTP id 8E78E1BC84DE; Wed, 5 Jan 2011 14:06:05 +0000 (UTC) X-SpamScore: -3 X-BigFish: VS-3(zzbb2cKzz1202hzz8275bhz2dh2a8h668h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: KIP:(null); UIP:(null); IPVD:NLI; H:az33egw02.freescale.net; RD:az33egw02.freescale.net; EFVD:NLI Received: from mail163-tx2 (localhost.localdomain [127.0.0.1]) by mail163-tx2 (MessageSwitch) id 1294236365442599_15887; Wed, 5 Jan 2011 14:06:05 +0000 (UTC) Received: from TX2EHSMHS015.bigfish.com (unknown [10.9.14.250]) by mail163-tx2.bigfish.com (Postfix) with ESMTP id 67CBC1B8052; Wed, 5 Jan 2011 14:06:05 +0000 (UTC) Received: from az33egw02.freescale.net (192.88.158.103) by TX2EHSMHS015.bigfish.com (10.9.99.115) with Microsoft SMTP Server (TLS) id 14.1.225.8; Wed, 5 Jan 2011 14:06:03 +0000 Received: from az33smr01.freescale.net (az33smr01.freescale.net [10.64.34.199]) by az33egw02.freescale.net (8.14.3/8.14.3) with ESMTP id p05E60Ut002941; Wed, 5 Jan 2011 07:06:00 -0700 (MST) Received: from ubuntu.ap.freescale.net (ubuntu-010192242196.ap.freescale.net [10.192.242.196]) by az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id p05E5olC010491; Wed, 5 Jan 2011 08:05:55 -0600 (CST) From: Shawn Guo To: , , , , , , , , , , , , CC: Shawn Guo Subject: [PATCH v3 01/10] net/fec: fix MMFR_OP type in fec_enet_mdio_write Date: Wed, 5 Jan 2011 22:07:28 +0800 Message-ID: <1294236457-17476-2-git-send-email-shawn.guo@freescale.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1294236457-17476-1-git-send-email-shawn.guo@freescale.com> References: <1294236457-17476-1-git-send-email-shawn.guo@freescale.com> MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org FEC_MMFR_OP_WRITE should be used than FEC_MMFR_OP_READ in a mdio write operation. It's probably a typo introduced by commit: e6b043d512fa8d9a3801bf5d72bfa3b8fc3b3cc8 netdev/fec.c: add phylib supporting to enable carrier detection (v2) Signed-off-by: Shawn Guo --- drivers/net/fec.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/fec.c b/drivers/net/fec.c index cce32d4..52e9ca8 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -651,8 +651,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, fep->mii_timeout = 0; init_completion(&fep->mdio_done); - /* start a read op */ - writel(FEC_MMFR_ST | FEC_MMFR_OP_READ | + /* start a write op */ + writel(FEC_MMFR_ST | FEC_MMFR_OP_WRITE | FEC_MMFR_PA(mii_id) | FEC_MMFR_RA(regnum) | FEC_MMFR_TA | FEC_MMFR_DATA(value), fep->hwp + FEC_MII_DATA);