From patchwork Sun Jan 2 14:35:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Nicolas_de_Peslo=C3=BCan?= X-Patchwork-Id: 77182 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F23BDB70B3 for ; Mon, 3 Jan 2011 01:36:02 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754618Ab1ABOfm (ORCPT ); Sun, 2 Jan 2011 09:35:42 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:50118 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754565Ab1ABOfl (ORCPT ); Sun, 2 Jan 2011 09:35:41 -0500 Received: from localhost.localdomain (unknown [88.175.177.37]) by smtp6-g21.free.fr (Postfix) with ESMTP id BA90782258; Sun, 2 Jan 2011 15:35:33 +0100 (CET) From: =?UTF-8?q?Nicolas=20de=20Peslo=C3=BCan?= To: bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org, fubar@us.ibm.com, davem@davemloft.net Cc: nicolas.2p.debian@free.fr Subject: [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries. Date: Sun, 2 Jan 2011 15:35:15 +0100 Message-Id: <1293978915-29674-1-git-send-email-nicolas.2p.debian@free.fr> X-Mailer: git-send-email 1.7.2.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Only two bonding parameters are exposed in /sys/module/bonding: num_grat_arp num_unsol_na Those values are not module global, but per device. The per device values are available in /sys/class/net//bonding. The values exposed in /sys/module/bonding are those given at module load time and only used as default values when creating a device. They are read-only and cannot change in any way. As such, they are mostly meaningless. --- drivers/net/bonding/bond_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index b1025b8..b7fd966 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -116,9 +116,9 @@ module_param(max_bonds, int, 0); MODULE_PARM_DESC(max_bonds, "Max number of bonded devices"); module_param(tx_queues, int, 0); MODULE_PARM_DESC(tx_queues, "Max number of transmit queues (default = 16)"); -module_param(num_grat_arp, int, 0644); +module_param(num_grat_arp, int, 0); MODULE_PARM_DESC(num_grat_arp, "Number of gratuitous ARP packets to send on failover event"); -module_param(num_unsol_na, int, 0644); +module_param(num_unsol_na, int, 0); MODULE_PARM_DESC(num_unsol_na, "Number of unsolicited IPv6 Neighbor Advertisements packets to send on failover event"); module_param(miimon, int, 0); MODULE_PARM_DESC(miimon, "Link check interval in milliseconds");