From patchwork Sun Dec 19 10:58:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 76118 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7FE4FB6EE9 for ; Sun, 19 Dec 2010 21:59:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755834Ab0LSK7M (ORCPT ); Sun, 19 Dec 2010 05:59:12 -0500 Received: from mail-ww0-f42.google.com ([74.125.82.42]:41062 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754587Ab0LSK7E (ORCPT ); Sun, 19 Dec 2010 05:59:04 -0500 Received: by wwi17 with SMTP id 17so1942557wwi.1 for ; Sun, 19 Dec 2010 02:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=gryIF2T9RUF/QD6FAs3NGs0GllXh2AyGODTzjy8Ud6Q=; b=VQEcmECpCCloE5RSOslZTFgCbw2hSslVkmekhfEQ92r0Fw698Tb+4HKBfwKiHT72rt cKLZxMVOv2hZ0gvQPI0K1DskpQb5UoupdOx8W5hGYmqYL936CaaordCu/wRBXeRgtFK9 CHMBaOPBvBLoR1n7J/GnBfeL2OEisS8nMf53I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=bppy1mKSALI80iTTbyEvsoo8+bm/bBmlW9pQlqll99T7gZ38N1JT0P5lzCm6++L9/U O4MtDOjw/2co9T5hBtsAIDUuyt9SQFBP8fqRXg9HSzgAMHvX/giUJJGoZXzxU51zyGj6 hlqlaREqFBsZd48mZzxj8+e+0NvdKZl0Mz5Nw= Received: by 10.216.82.9 with SMTP id n9mr3457435wee.35.1292756343184; Sun, 19 Dec 2010 02:59:03 -0800 (PST) Received: from localhost.localdomain (pat35-2-82-240-214-173.fbx.proxad.net [82.240.214.173]) by mx.google.com with ESMTPS id r6sm1212651weq.20.2010.12.19.02.59.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 19 Dec 2010 02:59:02 -0800 (PST) From: Jean-Michel Hautbois To: davem@davemloft.net Cc: richard.cochran@omicron.at, shemminger@vyatta.com, tj@kernel.org, randy.dunlap@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Michel Hautbois Subject: [PATCH 2/4] net: phy: printk issues fixed Date: Sun, 19 Dec 2010 11:58:49 +0100 Message-Id: <1292756331-3735-2-git-send-email-jhautbois@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1292756331-3735-1-git-send-email-jhautbois@gmail.com> References: <1292756331-3735-1-git-send-email-jhautbois@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When calling net link change, pr_info and printk where interleaved. Changed the way to print messages. Signed-off-by: Jean-Michel Hautbois --- drivers/net/phy/phy.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 5f23e8e..4ab48d7 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -44,14 +44,14 @@ */ void phy_print_status(struct phy_device *phydev) { - pr_info("PHY: %s - Link is %s", dev_name(&phydev->dev), - phydev->link ? "Up" : "Down"); if (phydev->link) - printk(" - %d/%s", phydev->speed, - DUPLEX_FULL == phydev->duplex ? - "Full" : "Half"); - - printk("\n"); + pr_info("PHY: %s - Link is up - %d/%s\n", + dev_name(&phydev->dev), + phydev->speed, + phydev->duplex == DUPLEX_FULL ? "Full" : "Half"); + else + pr_info("PHY: %s - Link is down\n", + dev_name(&phydev->dev)); } EXPORT_SYMBOL(phy_print_status);