From patchwork Thu Dec 9 01:42:41 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Levitsky X-Patchwork-Id: 74821 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 83731B708B for ; Thu, 9 Dec 2010 12:42:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754990Ab0LIBmu (ORCPT ); Wed, 8 Dec 2010 20:42:50 -0500 Received: from mail-bw0-f45.google.com ([209.85.214.45]:56047 "EHLO mail-bw0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794Ab0LIBmt (ORCPT ); Wed, 8 Dec 2010 20:42:49 -0500 Received: by bwz16 with SMTP id 16so2076098bwz.4 for ; Wed, 08 Dec 2010 17:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer; bh=WasGfaJe2RDyqPlFFklZZeF2jUA12HJm4FyKtvVestE=; b=eIjIpnmkqeivwWEsVNs8EFEypOeY2TiEsPLq3AVaAORHzgA1P2BcdZYA+DLgQRbI/g PcHObZBx4D4qAkdpY7FBNWUwO9iRdT5qyeSccuSzBn6Uicqt9pNQVNyrTDZhN0uccjGS tmX5YlDiDoY7zz1yfKaHOC+AQOi0pMrJDhvu0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer; b=FDqgrfaeT5tLxehfsvMCDNLe7ReVhB/48qbPMPAbC249eP5yGJmHWyi31N9v/kJrOI TvafnkqR0aHvxnxuUUgbTl2g0P0Ba65CB1GtSros5Tq9MsQfeeMk5qQUBdJVlDX/BLQ6 g98CB/IpRqG0v+eSUY7YxN746lndFUv0QgHNI= Received: by 10.204.48.84 with SMTP id q20mr2644835bkf.180.1291858966959; Wed, 08 Dec 2010 17:42:46 -0800 (PST) Received: from [10.0.0.2] (IGLD-84-228-198-105.inter.net.il [84.228.198.105]) by mx.google.com with ESMTPS id v25sm658993bkt.18.2010.12.08.17.42.43 (version=SSLv3 cipher=RC4-MD5); Wed, 08 Dec 2010 17:42:44 -0800 (PST) Subject: Re: [PATCH 0/5 V2] Firewire networking assorted fixes From: Maxim Levitsky To: linux1394-devel Cc: Stefan Richter , netdev@vger.kernel.org In-Reply-To: <1291779177.32420.8.camel@maxim-laptop> References: <1290996593-32416-1-git-send-email-maximlevitsky@gmail.com> <1291779177.32420.8.camel@maxim-laptop> Date: Thu, 09 Dec 2010 03:42:41 +0200 Message-ID: <1291858961.3331.4.camel@maxim-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2010-12-08 at 05:32 +0200, Maxim Levitsky wrote: > On Mon, 2010-11-29 at 04:09 +0200, Maxim Levitsky wrote: > > Hi, > > > > This is updated version of the patches. > > I updated the changelogs, addressed comments on patch #2 > > > > Best regards, > > Maxim Levitsky > > > > Today I have achieved the ultimate goal, > full support of firewire networking via NetworkManager. > > Currently it is patched with few hacks but much less that I expected. > > I also had to patch dhclient as it unfortunately sends raw packets > together with hardware header (ethernet of course...) > > I will soon clean up these hacks to turn them into patches and send to > developers. > > The kernel side needs only the attached patch. > It adds the link state detection to firewire-net > > Just for fun, this is screenshot that proves that NM works: > http://img210.imageshack.us/img210/6019/screenshotdjk.png And cleaned up patches that add the support attached. Will send these to NM and dhcp ML soon. Best regards, Maxim Levitsky From 93129738ca8450899e416420f630aee17c8301d5 Mon Sep 17 00:00:00 2001 From: Maxim Levitsky Date: Thu, 9 Dec 2010 00:30:55 +0200 Subject: [PATCH] NM: allow use of IPV4 over firewire Don't ignore these devices since NM works just fine with them iff the dhclient works. Patches are posted to make it work with firewire networking link Signed-off-by: Maxim Levitsky --- src/nm-udev-manager.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/nm-udev-manager.c b/src/nm-udev-manager.c index ff0ef68..3cd2970 100644 --- a/src/nm-udev-manager.c +++ b/src/nm-udev-manager.c @@ -408,7 +408,9 @@ net_add (NMUdevManager *self, GUdevDevice *device) g_return_if_fail (device != NULL); etype = g_udev_device_get_sysfs_attr_as_int (device, "type"); - if (etype != 1) { + + /* firewire devices are similiar to ethernet, so allow them too */ + if (etype != 1 && etype != 24) { nm_log_dbg (LOGD_HW, "ignoring interface with type %d", etype); return; /* Not using ethernet encapsulation, don't care */ } -- 1.7.1