From patchwork Thu Nov 18 18:17:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasiliy Kulikov X-Patchwork-Id: 72128 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0239CB71A4 for ; Fri, 19 Nov 2010 05:17:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760116Ab0KRSRN (ORCPT ); Thu, 18 Nov 2010 13:17:13 -0500 Received: from mail-ew0-f46.google.com ([209.85.215.46]:63347 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760095Ab0KRSRL (ORCPT ); Thu, 18 Nov 2010 13:17:11 -0500 Received: by mail-ew0-f46.google.com with SMTP id 8so2173391ewy.19 for ; Thu, 18 Nov 2010 10:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:cc:subject :date:message-id:x-mailer; bh=X/+pSg0caxjBbPPldQ4+0iHLZ5sKxD/UxfLDPGOr+60=; b=wwUvfnPoXL5YeQ1bnBnMonoXiPxa2PLvYiMldO4iqUk7mVkkch6owmTJiRa7B7FSia Ijd9ggtvV6uCKMh+bViCNv3YfgUl5wbN2FzrehJwbc25VbkHWbbf8Bz1eoGN8NLw8OhH qHmnhBWOqQCXy4i2/eXD0MRm0KGhkbeGpyU4s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=AWGLTdqr4O9O4q5ZHqqv2TXJowA/WN5d4Qu81PAvpvLrIGK4+UQyxDj3lRTKBeR5vy FUnizfVgopkmX0dud5VIdLVjyEMo4o2UxN5ONxgPvjj/9p5ZVAp1K4wRT5ICjkCctu2q u3GJ1ROuLSY+j+W1Jqi0aTF4Otyt5SNcSNPaI= Received: by 10.213.9.135 with SMTP id l7mr790928ebl.37.1290104230163; Thu, 18 Nov 2010 10:17:10 -0800 (PST) Received: from localhost (ppp91-77-42-172.pppoe.mtu-net.ru [91.77.42.172]) by mx.google.com with ESMTPS id b52sm630471eei.19.2010.11.18.10.17.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 18 Nov 2010 10:17:09 -0800 (PST) From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Sjur Braendeland , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] net: caif: spi: fix potential NULL dereference Date: Thu, 18 Nov 2010 21:17:05 +0300 Message-Id: <1290104226-31428-1-git-send-email-segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org alloc_netdev() is not checked here for NULL return value. dev is check instead. It might lead to NULL dereference of ndev. Signed-off-by: Vasiliy Kulikov --- Compile tested. Maybe dev is also must be checked here, but it looks like a trivial typo. drivers/net/caif/caif_spi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/caif/caif_spi.c b/drivers/net/caif/caif_spi.c index 8b4cea5..20da199 100644 --- a/drivers/net/caif/caif_spi.c +++ b/drivers/net/caif/caif_spi.c @@ -635,8 +635,8 @@ int cfspi_spi_probe(struct platform_device *pdev) ndev = alloc_netdev(sizeof(struct cfspi), "cfspi%d", cfspi_setup); - if (!dev) - return -ENODEV; + if (!ndev) + return -ENOMEM; cfspi = netdev_priv(ndev); netif_stop_queue(ndev);