From patchwork Sun Nov 14 20:08:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasiliy Kulikov X-Patchwork-Id: 71146 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 67D51B711C for ; Mon, 15 Nov 2010 07:09:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756655Ab0KNUIo (ORCPT ); Sun, 14 Nov 2010 15:08:44 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:37539 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756530Ab0KNUIl (ORCPT ); Sun, 14 Nov 2010 15:08:41 -0500 Received: by eye27 with SMTP id 27so2664610eye.19 for ; Sun, 14 Nov 2010 12:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:cc:subject :date:message-id:x-mailer; bh=QUrbXsilMj+uRkcF89y5sA457A59FT57Tdpw+22IORo=; b=l5QbPMTcCQGVRJ4npc1EgnzzU7rbhqfxGFF5dShmfuFNZG4qETvprzKVdSaSei5bQr 1mARkBYxBfX6fPFW10pVxsY3TBpqlF3y01Th2wmBPv355/FGNhuQlqU+tygQWT6YM5SC 1YahCaLNMeE/ebkkMoF16bYtyKREv3n7VmMrc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=CQKeW+k4cCaJsAhS42RuL3tc9NtLLW0th+ivqGUMeHHJVs7GHg4dq6U7DQr22MirG7 qz68DsInaMl6rrkZdE0UOrf50Lfjxa+J/7hiEm6av/KwD3wEVUpuALst4UTOTTyZv24v 4LV9FoZh3euh1oQNar+gVF2dqVtKrXwsOb89k= Received: by 10.213.2.200 with SMTP id 8mr4117031ebk.73.1289765319918; Sun, 14 Nov 2010 12:08:39 -0800 (PST) Received: from localhost (ppp85-140-234-48.pppoe.mtu-net.ru [85.140.234.48]) by mx.google.com with ESMTPS id q58sm5812246eeh.21.2010.11.14.12.08.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 14 Nov 2010 12:08:39 -0800 (PST) From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Eilon Greenstein , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: bnx2x: fix error value sign Date: Sun, 14 Nov 2010 23:08:34 +0300 Message-Id: <1289765315-6028-1-git-send-email-segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org bnx2x_init_one() should return negative value on error. By mistake it returns ENODEV instead of -ENODEV. Signed-off-by: Vasiliy Kulikov Acked-by: Eilon Greenstein --- Compile tested. drivers/net/bnx2x/bnx2x_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c index 4a6f0ea..be52edc 100644 --- a/drivers/net/bnx2x/bnx2x_main.c +++ b/drivers/net/bnx2x/bnx2x_main.c @@ -9064,7 +9064,7 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev, default: pr_err("Unknown board_type (%ld), aborting\n", ent->driver_data); - return ENODEV; + return -ENODEV; } cid_count += CNIC_CONTEXT_USE;