| Message ID | 1288545022-16393-1-git-send-email-segooon@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Oct 31, 2010 at 08:10:22PM +0300, Vasiliy Kulikov wrote: > Sometimes ax25_getname() doesn't initialize all members of fsa_digipeater > field of fsa struct. This structure is then copied to userland. It leads to > leaking of contents of kernel stack memory. We have to initialize them to zero. > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 26eaebf..a324d83 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -1392,6 +1392,7 @@ static int ax25_getname(struct socket *sock, struct sockaddr *uaddr, ax25_cb *ax25; int err = 0; + memset(&fsa->fsa_digipeater, 0, sizeof(fsa->fsa_digipeater)); lock_sock(sk); ax25 = ax25_sk(sk);
Sometimes ax25_getname() doesn't initialize all members of fsa_digipeater field of fsa struct. This structure is then copied to userland. It leads to leaking of contents of kernel stack memory. We have to initialize them to zero. Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> --- net/ax25/af_ax25.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)