From patchwork Sat Oct 30 14:26:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 69657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DE473B70CD for ; Sun, 31 Oct 2010 01:26:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172Ab0J3O0d (ORCPT ); Sat, 30 Oct 2010 10:26:33 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:40880 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754078Ab0J3O01 (ORCPT ); Sat, 30 Oct 2010 10:26:27 -0400 Received: by mail-ew0-f46.google.com with SMTP id 7so2736955ewy.19 for ; Sat, 30 Oct 2010 07:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=O7PvrAFoQlJ3gFTJjOpSSuMUmzraMB41HWrNkWKqqR0=; b=DYnaVg52jpE+PPZ5jsuz7vctHddJNPUEvA2YGjNAJotyw91tbzY0Boc8DIsXITM+8Z G0NGRgn5Ug9UKpeVuClSRTGYBCuOeESJsKjeHWrzlYDtZf0e1gEqfIGVrNq/95qjSkaq sQSDeBbaojFAGz3hFQa/XS955z3iEwiSobmls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=icZ2U91fOgfz5ZPlujjOGMwp6+uA0dUS57FqaprB4zoH03q0uopDvbFks9ZHJW74R1 FLMu2MLgAU2Ue83PdDmxFvpikd8fFnjO/rO9L9v8AP+B9+tDh7CswomWOsB55LWUozqe UNSN7g7MJ70zWkIVlOaoO90LebZTU/zxy7EwM= Received: by 10.213.35.72 with SMTP id o8mr6939927ebd.80.1288448786646; Sat, 30 Oct 2010 07:26:26 -0700 (PDT) Received: from localhost (ppp91-78-210-135.pppoe.mtu-net.ru [91.78.210.135]) by mx.google.com with ESMTPS id w20sm2614076eeh.6.2010.10.30.07.26.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 30 Oct 2010 07:26:25 -0700 (PDT) From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Marcel Holtmann , "Gustavo F. Padovan" , "David S. Miller" , Eric Dumazet , Thadeu Lima de Souza Cascardo , Tejun Heo , Jiri Kosina , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] bluetooth: bnep: fix information leak to userland Date: Sat, 30 Oct 2010 18:26:21 +0400 Message-Id: <1288448782-5582-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Structure bnep_conninfo is copied to userland with the field "device" that has the last elements unitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov Acked-by: Marcel Holtmann --- Compile tested. net/bluetooth/bnep/core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c index f10b41f..5868597 100644 --- a/net/bluetooth/bnep/core.c +++ b/net/bluetooth/bnep/core.c @@ -648,6 +648,7 @@ int bnep_del_connection(struct bnep_conndel_req *req) static void __bnep_copy_ci(struct bnep_conninfo *ci, struct bnep_session *s) { + memset(ci, 0, sizeof(*ci)); memcpy(ci->dst, s->eh.h_source, ETH_ALEN); strcpy(ci->device, s->dev->name); ci->flags = s->flags;