From patchwork Sat Oct 30 09:04:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 69650 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D66FFB70A8 for ; Sat, 30 Oct 2010 20:05:53 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106Ab0J3JEy (ORCPT ); Sat, 30 Oct 2010 05:04:54 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:37337 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859Ab0J3JEi (ORCPT ); Sat, 30 Oct 2010 05:04:38 -0400 Received: by mail-ey0-f174.google.com with SMTP id 27so2582722eye.19 for ; Sat, 30 Oct 2010 02:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=db5JpNQ89ym6I5MWE88FYSNt8+UG8OUyIUvD2i4PfbY=; b=RWjP1NLQw/5ZCzpgzJpvkD1xIo/jY7BqOtdNN535L3x/s6il+544T5RNPtAET3LfaV CNlcO1pRxcepFYOFWHBxVCoBRwad8OV9U5b3K6DBtLZ2SHRZ9wMudgw0g8/rM8WJXJTd 46QYCjy4z+qS8SqwxbWyb7BgTsAI7qkN+82+A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=MnGkucGmJpXbKmPEcUQWMOinwA42desOXJdZhEa0PbliPNhv5zjtjoIxFwaLWeHGic QqscgRvTubNefLtple25YvI/zPZWXyimNRXRVmK6M6XuENvbmIyjc8iFDDm3taj0J8EI /vJJUkuCPSEWc0grqzXz2KEOfy+WhRx0kkim4= Received: by 10.213.14.70 with SMTP id f6mr334686eba.7.1288429477655; Sat, 30 Oct 2010 02:04:37 -0700 (PDT) Received: from localhost (ppp91-78-210-135.pppoe.mtu-net.ru [91.78.210.135]) by mx.google.com with ESMTPS id q58sm2420303eeh.21.2010.10.30.02.04.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 30 Oct 2010 02:04:36 -0700 (PDT) From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Karsten Keil , Arnaldo Carvalho de Melo , "David S. Miller" , Tejun Heo , Eric Paris , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] isdn: mISDN: socket: fix information leak to userland Date: Sat, 30 Oct 2010 13:04:33 +0400 Message-Id: <1288429473-21864-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Structure mISDN_devinfo is copied to userland with the field "name" that has the last elements unitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/isdn/mISDN/socket.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 3232206..7446d8b 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c @@ -392,6 +392,7 @@ data_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) if (dev) { struct mISDN_devinfo di; + memset(&di, 0, sizeof(di)); di.id = dev->id; di.Dprotocols = dev->Dprotocols; di.Bprotocols = dev->Bprotocols | get_all_Bprotocols(); @@ -672,6 +673,7 @@ base_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) if (dev) { struct mISDN_devinfo di; + memset(&di, 0, sizeof(di)); di.id = dev->id; di.Dprotocols = dev->Dprotocols; di.Bprotocols = dev->Bprotocols | get_all_Bprotocols();