diff mbox

[1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros

Message ID 1288235555-24675-1-git-send-email-harvey.harrison@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Harvey Harrison Oct. 28, 2010, 3:12 a.m. UTC
readl/writel swap to little-endian internally.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_int.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Shreyas Bhatewara Oct. 29, 2010, 6:17 p.m. UTC | #1
Harvey,
Thanks for working on this. The change looks good.

Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>


On Wed, 27 Oct 2010, Harvey Harrison wrote:

> readl/writel swap to little-endian internally.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_int.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
> index 8a2f471..edf2288 100644
> --- a/drivers/net/vmxnet3/vmxnet3_int.h
> +++ b/drivers/net/vmxnet3/vmxnet3_int.h
> @@ -330,14 +330,14 @@ struct vmxnet3_adapter {
>  };
>  
>  #define VMXNET3_WRITE_BAR0_REG(adapter, reg, val)  \
> -	writel(cpu_to_le32(val), (adapter)->hw_addr0 + (reg))
> +	writel((val), (adapter)->hw_addr0 + (reg))
>  #define VMXNET3_READ_BAR0_REG(adapter, reg)        \
> -	le32_to_cpu(readl((adapter)->hw_addr0 + (reg)))
> +	readl((adapter)->hw_addr0 + (reg))
>  
>  #define VMXNET3_WRITE_BAR1_REG(adapter, reg, val)  \
> -	writel(cpu_to_le32(val), (adapter)->hw_addr1 + (reg))
> +	writel((val), (adapter)->hw_addr1 + (reg))
>  #define VMXNET3_READ_BAR1_REG(adapter, reg)        \
> -	le32_to_cpu(readl((adapter)->hw_addr1 + (reg)))
> +	readl((adapter)->hw_addr1 + (reg))
>  
>  #define VMXNET3_WAKE_QUEUE_THRESHOLD(tq)  (5)
>  #define VMXNET3_RX_ALLOC_THRESHOLD(rq, ring_idx, adapter) \
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Oct. 30, 2010, 11:19 p.m. UTC | #2
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 27 Oct 2010 20:12:34 -0700

> readl/writel swap to little-endian internally.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index 8a2f471..edf2288 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -330,14 +330,14 @@  struct vmxnet3_adapter {
 };
 
 #define VMXNET3_WRITE_BAR0_REG(adapter, reg, val)  \
-	writel(cpu_to_le32(val), (adapter)->hw_addr0 + (reg))
+	writel((val), (adapter)->hw_addr0 + (reg))
 #define VMXNET3_READ_BAR0_REG(adapter, reg)        \
-	le32_to_cpu(readl((adapter)->hw_addr0 + (reg)))
+	readl((adapter)->hw_addr0 + (reg))
 
 #define VMXNET3_WRITE_BAR1_REG(adapter, reg, val)  \
-	writel(cpu_to_le32(val), (adapter)->hw_addr1 + (reg))
+	writel((val), (adapter)->hw_addr1 + (reg))
 #define VMXNET3_READ_BAR1_REG(adapter, reg)        \
-	le32_to_cpu(readl((adapter)->hw_addr1 + (reg)))
+	readl((adapter)->hw_addr1 + (reg))
 
 #define VMXNET3_WAKE_QUEUE_THRESHOLD(tq)  (5)
 #define VMXNET3_RX_ALLOC_THRESHOLD(rq, ring_idx, adapter) \