From patchwork Sun Oct 24 20:20:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Dillow X-Patchwork-Id: 69047 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3986BB70A8 for ; Mon, 25 Oct 2010 07:20:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166Ab0JXUU3 (ORCPT ); Sun, 24 Oct 2010 16:20:29 -0400 Received: from amavis-smtp.knology.net ([75.76.199.6]:45085 "EHLO amavis-smtp.knology.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759152Ab0JXUU2 (ORCPT ); Sun, 24 Oct 2010 16:20:28 -0400 Received: from localhost (amavis-smtp [127.0.0.1]) by amavis-smtp.knology.net (Postfix) with ESMTP id 7E87988739; Sun, 24 Oct 2010 16:20:20 -0400 (EDT) Received: from smtp12.knology.net ([75.76.199.9]) by localhost (amavis-smtp.knology.net [75.76.199.6]) (amavisd-new, port 10024) with LMTP id tpgSKmna4x8h; Sun, 24 Oct 2010 16:20:19 -0400 (EDT) Received: from shed.thedillows.org (unknown [207.98.218.89]) by smtp12.knology.net (Postfix) with ESMTP id A7260520005B; Sun, 24 Oct 2010 16:19:55 -0400 (EDT) Received: from obelisk.thedillows.org (obelisk.thedillows.org [192.168.0.10]) by shed.thedillows.org (8.14.4/8.14.4) with ESMTP id o9OKKLU9020663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Oct 2010 16:20:21 -0400 Received: from obelisk.thedillows.org (localhost [127.0.0.1]) by obelisk.thedillows.org (8.14.4/8.14.3) with ESMTP id o9OKKLQ6025204; Sun, 24 Oct 2010 16:20:21 -0400 Received: (from dad@localhost) by obelisk.thedillows.org (8.14.4/8.14.4/Submit) id o9OKKLBH025203; Sun, 24 Oct 2010 16:20:21 -0400 X-Authentication-Warning: obelisk.thedillows.org: dad set sender to dave@thedillows.org using -f From: David Dillow To: netdev@vger.kernel.org Cc: davem@davemloft.net Subject: [PATCH 1/2] typhoon: wait for RX mode commands to finish Date: Sun, 24 Oct 2010 16:20:20 -0400 Message-Id: <1287951621-25170-1-git-send-email-dave@thedillows.org> X-Mailer: git-send-email 1.7.2.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When adding VLAN devices, we can get several calls to typhoon_set_rx_mode() in quick succession. Because we didn't wait for the commands to complete, we could run out of command descriptors and fail to set the RX mode. Signed-off-by: David Dillow --- drivers/net/typhoon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 1cc6713..5957d4e 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev) filter |= TYPHOON_RX_FILTER_MCAST_HASH; } - INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); + INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); xp_cmd.parm1 = filter; typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL); }