| Message ID | 1287951621-25170-1-git-send-email-dave@thedillows.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: David Dillow <dave@thedillows.org> Date: Sun, 24 Oct 2010 16:20:20 -0400 > When adding VLAN devices, we can get several calls to > typhoon_set_rx_mode() in quick succession. Because we didn't wait for > the commands to complete, we could run out of command descriptors and > fail to set the RX mode. > > Signed-off-by: David Dillow <dave@thedillows.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 1cc6713..5957d4e 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev) filter |= TYPHOON_RX_FILTER_MCAST_HASH; } - INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); + INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); xp_cmd.parm1 = filter; typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL); }
When adding VLAN devices, we can get several calls to typhoon_set_rx_mode() in quick succession. Because we didn't wait for the commands to complete, we could run out of command descriptors and fail to set the RX mode. Signed-off-by: David Dillow <dave@thedillows.org> --- drivers/net/typhoon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)