From patchwork Fri Oct 8 14:02:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 67217 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 825F0B70A7 for ; Sat, 9 Oct 2010 01:02:56 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758170Ab0JHOCJ (ORCPT ); Fri, 8 Oct 2010 10:02:09 -0400 Received: from yop.chewa.net ([91.121.105.214]:47819 "EHLO yop.chewa.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758127Ab0JHOCF (ORCPT ); Fri, 8 Oct 2010 10:02:05 -0400 Received: by yop.chewa.net (Postfix, from userid 1007) id 961BC94D; Fri, 8 Oct 2010 16:02:03 +0200 (CEST) From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= To: netdev@vger.kernel.org Cc: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= Subject: [PATCH 2/4] Phonet: advise against enabling the pipe controller Date: Fri, 8 Oct 2010 17:02:01 +0300 Message-Id: <1286546523-3340-2-git-send-email-remi@remlab.net> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1286546523-3340-1-git-send-email-remi@remlab.net> References: <1286546523-3340-1-git-send-email-remi@remlab.net> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rémi Denis-Courmont As it currently is, the new code path is not compatible with existing Nokia modems. This would break existing userspace for Nokia modem, such as the existing oFono ISI driver. Signed-off-by: Rémi Denis-Courmont --- net/phonet/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig index 901956a..a4fceb8 100644 --- a/net/phonet/Kconfig +++ b/net/phonet/Kconfig @@ -24,4 +24,5 @@ config PHONET_PIPECTRLR data with Nokia Slim modems like WG2.5 used on ST-Ericsson U8500 platform. - If unsure, say N. + This option is incompatible with older Nokia modems. + Say N here unless you really know what you are doing.