From patchwork Sat Aug 28 05:08:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 62893 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 792B3B7118 for ; Sat, 28 Aug 2010 15:15:47 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294Ab0H1FPn (ORCPT ); Sat, 28 Aug 2010 01:15:43 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:45456 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565Ab0H1FPm (ORCPT ); Sat, 28 Aug 2010 01:15:42 -0400 Received: by pzk9 with SMTP id 9so1321884pzk.19 for ; Fri, 27 Aug 2010 22:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=6whEKvPFjs+3MlGFhPKCvk/zTaAt+b3W4yE75zYFz1Y=; b=pfgQvkw1G1IqivNmnVCJ/igpiw1Ig01HNH1bl5tBhpnwZ+du/mrtF660vN22VayzU/ ir1hn1+P0U+sBz1MVuyIsZOppWmh3SzLQ82ba4BFQcsgltK6XWmJB7TJw4igcHj9HtIM vvMlPmyjNXQCmE/BB4jV9yLxlgSi2gRkRTGHA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=YXae9a9Vs5jaG4ygQ+JRokJYnMEjxiURM3Fjez0QG/atCML4V3qZmwekWDeyUC9a2L u4FkP5RKiAzlg02yVE8tZNkiUZdY6hl532XwrRixOna+xFiYHEb0tLIPACQk3Y5iDL07 6gbfKZLcEaaoFJWZRaOc2+wtPsExZBcujo6cI= Received: by 10.114.133.14 with SMTP id g14mr1599142wad.192.1282972536888; Fri, 27 Aug 2010 22:15:36 -0700 (PDT) Received: from localhost (p17219-adsau04yokonib3-acca.kanagawa.ocn.ne.jp [60.43.121.219]) by mx.google.com with ESMTPS id r37sm1476818wak.23.2010.08.27.22.15.34 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Aug 2010 22:15:36 -0700 (PDT) From: Akinobu Mita To: netdev@vger.kernel.org Cc: Akinobu Mita , Ion Badulescu , "David S. Miller" Subject: [PATCH] starfire: use BUILD_BUG_ON for netdrv_addr_t Date: Sat, 28 Aug 2010 14:08:45 +0900 Message-Id: <1282972125-9968-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.6.0.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Detect size mismatch for netdrv_addr_t at build time rather than checking at module load time. Signed-off-by: Akinobu Mita Cc: Ion Badulescu Cc: "David S. Miller" Cc: netdev@vger.kernel.org --- drivers/net/starfire.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 26c3634..c3bf288 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -2078,11 +2078,7 @@ static int __init starfire_init (void) printk(KERN_INFO DRV_NAME ": polling (NAPI) enabled\n"); #endif - /* we can do this test only at run-time... sigh */ - if (sizeof(dma_addr_t) != sizeof(netdrv_addr_t)) { - printk("This driver has dma_addr_t issues, please send email to maintainer\n"); - return -ENODEV; - } + BUILD_BUG_ON(sizeof(dma_addr_t) != sizeof(netdrv_addr_t)); return pci_register_driver(&starfire_driver); }