From patchwork Fri Aug 13 09:44:56 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 61676 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 29375B70E6 for ; Fri, 13 Aug 2010 19:52:30 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758427Ab0HMJwY (ORCPT ); Fri, 13 Aug 2010 05:52:24 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:37925 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909Ab0HMJwY (ORCPT ); Fri, 13 Aug 2010 05:52:24 -0400 X-Greylist: delayed 445 seconds by postgrey-1.27 at vger.kernel.org; Fri, 13 Aug 2010 05:52:23 EDT Received: from [172.31.4.142] (unknown [172.31.4.142]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 0188B1639BD; Fri, 13 Aug 2010 11:44:56 +0200 (CEST) Subject: [PATCH] iputils: arping fails to set correct broadcast address From: Jesper Dangaard Brouer To: YOSHIFUJI Hideaki Cc: netdev@vger.kernel.org, 585591@bugs.debian.org, Noah Meyerhans , Paul Martin , hawk@comx.dk Organization: ComX Networks A/S Date: Fri, 13 Aug 2010 11:44:56 +0200 Message-Id: <1281692696.23856.37.camel@firesoul.comx.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Paul Martin There seems to have been introduced a bug in iputils release s20100418. This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git (git commit fe342ca3148) The regression is caused by commit 56018bf1b3 arping: Support link-layer type with larger link-layer address. As reported by: Paul Martin in Debian bugreport #585591. There's a logic error in the function that parses the interface's broadcast address, causing it not to fill the broadcast address array correctly. Please apply. Reported-by: Paul Martin Tested-by: Jesper Dangaard Brouer Signed-off-by: Jesper Dangaard Brouer --- arping.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arping.c b/arping.c index 9bd6927..2613a12 100644 --- a/arping.c +++ b/arping.c @@ -336,7 +336,7 @@ void set_device_broadcast(char *device, unsigned char *ba, size_t balen) } for (p = ba, ch = 0; p < ba + balen; p++, ch += 3) - *p++ = strtoul(brdcast->value + ch * 3, NULL, 16); + *p = strtoul(brdcast->value + ch, NULL, 16); return; }