Message ID | 1281383448-14050-1-git-send-email-segooon@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Kulikov Vasiliy <segooon@gmail.com> Date: Mon, 9 Aug 2010 23:50:47 +0400 > Driver should call disable_pci_device() if it returns from pci_probe() > with error. > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Applied, but as previously mentioned disable_pci_device() is wrong. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/hardware/avm/t1pci.c b/drivers/isdn/hardware/avm/t1pci.c index 5a3f830..a79eb5a 100644 --- a/drivers/isdn/hardware/avm/t1pci.c +++ b/drivers/isdn/hardware/avm/t1pci.c @@ -210,6 +210,7 @@ static int __devinit t1pci_probe(struct pci_dev *dev, if (retval != 0) { printk(KERN_ERR "t1pci: no AVM-T1-PCI at i/o %#x, irq %d detected, mem %#x\n", param.port, param.irq, param.membase); + pci_disable_device(dev); return -ENODEV; } return 0;
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/isdn/hardware/avm/t1pci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)