| Message ID | 1281383439-13988-1-git-send-email-segooon@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Kulikov Vasiliy <segooon@gmail.com> Date: Mon, 9 Aug 2010 23:50:37 +0400 > Driver should call disable_pci_device() if it returns from pci_probe() > with error. > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Applied, but please fix the template you're using for the commit message header and the message itself, because in all of your patches you've transposed "disable" and "pci" in "pci_disable_device()" So I have to fix it up two times in every patch I apply of your's. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/hardware/avm/c4.c b/drivers/isdn/hardware/avm/c4.c index 7715d32..d3530f6 100644 --- a/drivers/isdn/hardware/avm/c4.c +++ b/drivers/isdn/hardware/avm/c4.c @@ -1273,6 +1273,7 @@ static int __devinit c4_probe(struct pci_dev *dev, if (retval != 0) { printk(KERN_ERR "c4: no AVM-C%d at i/o %#x, irq %d detected, mem %#x\n", nr, param.port, param.irq, param.membase); + pci_disable_device(dev); return -ENODEV; } return 0;
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/isdn/hardware/avm/c4.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)