From patchwork Tue Aug 3 00:05:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Mattock X-Patchwork-Id: 60704 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43130B70DA for ; Tue, 3 Aug 2010 10:05:29 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686Ab0HCAFL (ORCPT ); Mon, 2 Aug 2010 20:05:11 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:47320 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab0HCAFJ (ORCPT ); Mon, 2 Aug 2010 20:05:09 -0400 Received: by pvc7 with SMTP id 7so1492511pvc.19 for ; Mon, 02 Aug 2010 17:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=+qm76eONLF7I/+h8bb0BVXc4UYNiLuxJ1LoDuOw0z9w=; b=n5PosExASg60l1POmZRJJ1UBAk1bWpO+aMqmVFCLds+mrNykuKMyI+7O3jrRwN0wSM JufjEF3Br9C4nB1yMVnwg0XHdP6sIyGzl5om22FubcXH5o2SIPFP2EtDsjkuvEHKN2pG K1nBUFKB0ArrEJzYXOH4ONvpHEJdrTUbWtyVE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=pR5hHQnfHPhFPyA5KbJhbG9vOC9wUEt4ygV0LJLvhwGNorLnj5Scg+WmseJdCZafly cPiz5g7ujpP6DUTebK6K7A85D0UzaQ0RS2PJ54z8OdCFvWD/iDua9BHooIyLjjyiw9RL U3iPEG48OdjA13lFOjt/0VTBfQzq+qrmIz7nw= Received: by 10.114.88.18 with SMTP id l18mr8152515wab.175.1280793908767; Mon, 02 Aug 2010 17:05:08 -0700 (PDT) Received: from localhost.localdomain ([76.91.45.220]) by mx.google.com with ESMTPS id n32sm12390266wag.11.2010.08.02.17.05.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Aug 2010 17:05:08 -0700 (PDT) From: "Justin P. Mattock" To: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, j@w1.fi, linville@tuxdriver.com, "Justin P. Mattock" Subject: [PATCH]hostap:hostap_hw.c Fix variable 'fc' set but not used Date: Mon, 2 Aug 2010 17:05:06 -0700 Message-Id: <1280793906-1810-1-git-send-email-justinmattock@gmail.com> X-Mailer: git-send-email 1.7.1.rc1.21.gf3bd6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The below fixes a build wanring from GCC. CC [M] drivers/net/wireless/hostap/hostap_plx.o In file included from drivers/net/wireless/hostap/hostap_plx.c:264:0: drivers/net/wireless/hostap/hostap_hw.c: In function 'prism2_tx_80211': drivers/net/wireless/hostap/hostap_hw.c:1816:18: warning: variable 'fc' set but not used Removing fc from this just introduces a new warning CC [M] drivers/net/wireless/hostap/hostap_plx.o In file included from drivers/net/wireless/hostap/hostap_plx.c:264:0: drivers/net/wireless/hostap/hostap_hw.c: In function 'prism2_tx_80211': drivers/net/wireless/hostap/hostap_hw.c:1839:3: warning: statement with no effect So I went and removed the whole thing. Let me know if theres another solution. Signed-off-by: Justin P. Mattock --- drivers/net/wireless/hostap/hostap_hw.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/hostap/hostap_hw.c b/drivers/net/wireless/hostap/hostap_hw.c index e9d9d62..d734f3e 100644 --- a/drivers/net/wireless/hostap/hostap_hw.c +++ b/drivers/net/wireless/hostap/hostap_hw.c @@ -1813,7 +1813,7 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) struct hfa384x_tx_frame txdesc; struct hostap_skb_tx_data *meta; int hdr_len, data_len, idx, res, ret = -1; - u16 tx_control, fc; + u16 tx_control; iface = netdev_priv(dev); local = iface->local; @@ -1836,7 +1836,6 @@ static int prism2_tx_80211(struct sk_buff *skb, struct net_device *dev) /* skb->data starts with txdesc->frame_control */ hdr_len = 24; skb_copy_from_linear_data(skb, &txdesc.frame_control, hdr_len); - fc = le16_to_cpu(txdesc.frame_control); if (ieee80211_is_data(txdesc.frame_control) && ieee80211_has_a4(txdesc.frame_control) && skb->len >= 30) {