From patchwork Sat Jul 31 16:33:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 60437 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05211B70A4 for ; Sun, 1 Aug 2010 02:34:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499Ab0GaQeU (ORCPT ); Sat, 31 Jul 2010 12:34:20 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:40053 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978Ab0GaQeS (ORCPT ); Sat, 31 Jul 2010 12:34:18 -0400 Received: by ewy23 with SMTP id 23so968703ewy.19 for ; Sat, 31 Jul 2010 09:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=XwNkrxMKdL+6lFH1jUaZ1Cg8TipFZcqRshkqJEQ9fqk=; b=h+aH3bhDJePaxPxkJ5tIN7SiXy/34n+XOYYkfAX/2QuldvpLP+qJsssd1GQBk+2P+E WpNM2l8yUKTXE3ZHNoUz8IpIVd5MDxrxrFL1tWEmLfRC98RydP6D3FTxsrQimktULkin vgACJYRlCeXRKiRTuGzRij8hluZ+iJSIlFicM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=QukC+H0gHaWqhe9etMREFChGcqxpU1a5oBhnNji6/vA3gjbEOfUuPQoqZ1z2S0GAmK Iyqathcf+pahQaQIaiWOCwBVQTWkcgiljqSMI5uXxqIxuTQT56YlTvlNkJajMdpIJawF JNrT4MMS8JnJdQMA3v+PmCLhwJhk4obBFrGCM= Received: by 10.213.17.66 with SMTP id r2mr1638942eba.37.1280594057202; Sat, 31 Jul 2010 09:34:17 -0700 (PDT) Received: from localhost ([213.87.88.249]) by mx.google.com with ESMTPS id v59sm5385734eeh.10.2010.07.31.09.34.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 31 Jul 2010 09:34:16 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Luciano Coelho , "John W. Linville" , Juuso Oikarinen , Teemu Paasikivi , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] net: wl12xx: do not use kfree'd memory Date: Sat, 31 Jul 2010 20:33:59 +0400 Message-Id: <1280594039-3246-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after wl1271_dump(). Signed-off-by: Kulikov Vasiliy Acked-by: Juuso Oikarinen --- drivers/net/wireless/wl12xx/wl1271_spi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c index 96d25fb..4cb99c5 100644 --- a/drivers/net/wireless/wl12xx/wl1271_spi.c +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c @@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl) spi_message_add_tail(&t, &m); spi_sync(wl_to_spi(wl), &m); - kfree(cmd); - wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN); + kfree(cmd); } #define WL1271_BUSY_WORD_TIMEOUT 1000