From patchwork Fri Jul 30 11:10:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 60353 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A4E4FB70B4 for ; Fri, 30 Jul 2010 21:11:17 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758408Ab0G3LLO (ORCPT ); Fri, 30 Jul 2010 07:11:14 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:39676 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758097Ab0G3LLL (ORCPT ); Fri, 30 Jul 2010 07:11:11 -0400 Received: by ewy23 with SMTP id 23so579360ewy.19 for ; Fri, 30 Jul 2010 04:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=EEzYxYhSCBFDvzXeNqdxFK+6ibRiQchjNK9kTYlkNK4=; b=m5xiM7Syug4jhuyIQDDUIYVrW/jr+x2td2arZWUEylKfck3tYZerC6poHRYSxx3IbO HhJNY+D3UvmDWuTSkjhQVdc9wujTMGU0Mv/y1Ctb/7wS8+0H/QtRchxwSMYR1HoOtiWv 5PeY0qc/RP7YkPFO/hXwoRn72uQw/2jaWl3Mg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=G6l+zInr85vXJq6P+Q52ccQGPVlHYXMgxiZ3IemDmTlXbPM8EV1ozHJAvLAcOn5szd djyHiREolZZ2Uli4JmXhQ41qPsDhqfzJGOIi89N7vAo89XCwewynbkNswwW6UAW5U1SI 8LQAbg/JGtQQAYSjG6tNBYwaq0hQNEJ2Oe5wU= Received: by 10.213.32.17 with SMTP id a17mr1141298ebd.11.1280488269952; Fri, 30 Jul 2010 04:11:09 -0700 (PDT) Received: from localhost ([213.87.87.75]) by mx.google.com with ESMTPS id v59sm2947000eeh.16.2010.07.30.04.10.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 30 Jul 2010 04:11:08 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Trond Myklebust , "J. Bruce Fields" , Neil Brown , "David S. Miller" , Jeff Layton , Steve Dickson , Suresh Jayaraman , Kevin Coffman , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 9/9] sunrpc: auth_gss: misused copy_to_user() return value Date: Fri, 30 Jul 2010 15:10:34 +0400 Message-Id: <1280488234-21223-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org copy_to_user() returns nonzero value on error, this value may be any value between 0 and requested count, not only requested count. Signed-off-by: Kulikov Vasiliy --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 8da2a0e..232d7dc 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -610,7 +610,7 @@ gss_pipe_upcall(struct file *filp, struct rpc_pipe_msg *msg, unsigned long left; left = copy_to_user(dst, data, mlen); - if (left == mlen) { + if (left) msg->errno = -EFAULT; return -EFAULT; }