From patchwork Wed Jul 28 00:25:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gregkh@suse.de X-Patchwork-Id: 60076 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AFB12100943 for ; Wed, 28 Jul 2010 10:34:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398Ab0G1AeE (ORCPT ); Tue, 27 Jul 2010 20:34:04 -0400 Received: from kroah.org ([198.145.64.141]:57040 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658Ab0G1Adz (ORCPT ); Tue, 27 Jul 2010 20:33:55 -0400 Received: from localhost (c-24-16-163-131.hsd1.wa.comcast.net [24.16.163.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id 68156483C7; Tue, 27 Jul 2010 17:33:54 -0700 (PDT) Subject: Patch "IPv6: only notify protocols if address is completely gone" has been added to the 2.6.34-stable tree To: shemminger@vyatta.com, davem@davemloft.net, emils.tantilov@gmail.com, emil.s.tantilov@intel.com, gregkh@suse.de, greg@kroah.com, netdev@vger.kernel.org Cc: , From: Date: Tue, 27 Jul 2010 17:25:00 -0700 In-Reply-To: <20100524113300.2ef38e12@nehalam> Message-ID: <12802767002169@site> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a note to let you know that I've just added the patch titled IPv6: only notify protocols if address is completely gone to the 2.6.34-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ipv6-only-notify-protocols-if-address-is-completely-gone.patch and it can be found in the queue-2.6.34 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From shemminger@vyatta.com Tue Jul 27 16:57:29 2010 From: Stephen Hemminger Date: Mon, 24 May 2010 11:33:00 -0700 Subject: IPv6: only notify protocols if address is completely gone To: Emil S Tantilov , "David S. Miller" , Greg KH Cc: NetDev , "Tantilov, Emil S" , stable@kernel.org Message-ID: <20100524113300.2ef38e12@nehalam> From: Stephen Hemminger (cherry picked from commit 8595805aafc8b077e01804c9a3668e9aa3510e89) The notifier for address down should only be called if address is completely gone, not just being marked as tentative on link transition. The code in net-next would case bonding/sctp/s390 to see address disappear on link down, but they would never see it reappear on link up. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/addrconf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Patches currently in stable-queue which might be from shemminger@vyatta.com are queue-2.6.34/sky2-restore-multicast-after-restart.patch queue-2.6.34/ipv6-keep-route-for-tentative-address.patch queue-2.6.34/ipv6-only-notify-protocols-if-address-is-completely-gone.patch queue-2.6.34/ipv6-fix-null-reference-in-proxy-neighbor-discovery.patch queue-2.6.34/bridge-fdb-cleanup-runs-too-often.patch -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2729,7 +2729,9 @@ static int addrconf_ifdown(struct net_de write_unlock_bh(&idev->lock); __ipv6_ifa_notify(RTM_DELADDR, ifa); - atomic_notifier_call_chain(&inet6addr_chain, NETDEV_DOWN, ifa); + if (ifa->dead) + atomic_notifier_call_chain(&inet6addr_chain, + NETDEV_DOWN, ifa); in6_ifa_put(ifa); write_lock_bh(&idev->lock);