From patchwork Fri Jul 23 16:44:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 59819 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 606F21007D2 for ; Sat, 24 Jul 2010 02:45:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757500Ab0GWQo7 (ORCPT ); Fri, 23 Jul 2010 12:44:59 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:52299 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727Ab0GWQo6 (ORCPT ); Fri, 23 Jul 2010 12:44:58 -0400 Received: by ewy23 with SMTP id 23so178790ewy.19 for ; Fri, 23 Jul 2010 09:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=3/aLeqmKSTADV+j8Nff29Cc/NVCGKfqcMzG+aVThBjk=; b=nuLoVoJ5FAA1C7fLHzPk9im/PApXAcYgIrFO986ecTSDrkSdIaE7ikqiHweUw3Z7z5 O79FNyMEyKk8Umn2lSsr+LZjTss3xIk90KA77HLBpeddefu0cASLkK3N8f4j0GYYSwrL pKPtbL0uJ8No1X8CRnrlA70hTACZBcxJ2zqX8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=kEP39omNTCQ4OxIHrdYGcLRTeRvTd4C6DkYfxDWSxbupikaosi9tacT1WNEQf/3cTC dyFnBRLtPnCdUE7cwPQytKFBlUKQt7AfHFqocJyFfruC3wSBGTJCIBV1y2TDfuqxfl6o U3225d2TCLv/6vB+MXRV0IQNE+vGGUW73tAsA= Received: by 10.213.31.146 with SMTP id y18mr3457842ebc.59.1279903496795; Fri, 23 Jul 2010 09:44:56 -0700 (PDT) Received: from localhost ([213.87.80.247]) by mx.google.com with ESMTPS id a48sm662457eei.0.2010.07.23.09.44.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 23 Jul 2010 09:44:55 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Steffen Klassert , "David S. Miller" , Eric Dumazet , Ben Hutchings , Alexey Dobriyan , Joe Perches , netdev@vger.kernel.org Subject: [PATCH] net: 3c59x: fix leak of iomaps Date: Fri, 23 Jul 2010 20:44:44 +0400 Message-Id: <1279903485-28247-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If vortex_probe1() fails we should unmap ioaddr mapped earlier. Signed-off-by: Kulikov Vasiliy --- drivers/net/3c59x.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 9b137e1..ebd4c19 100644 --- a/drivers/net/3c59x.c +++ b/drivers/net/3c59x.c @@ -1029,6 +1029,7 @@ static int __devinit vortex_init_one(struct pci_dev *pdev, rc = vortex_probe1(&pdev->dev, ioaddr, pdev->irq, ent->driver_data, unit); if (rc < 0) { + pci_iounmap(pdev, ioaddr); pci_disable_device(pdev); goto out; }