From patchwork Sat Jul 17 15:21:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 59141 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CE583B6EFF for ; Sun, 18 Jul 2010 01:21:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760019Ab0GQPVT (ORCPT ); Sat, 17 Jul 2010 11:21:19 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:53990 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755499Ab0GQPVR (ORCPT ); Sat, 17 Jul 2010 11:21:17 -0400 Received: by ewy23 with SMTP id 23so1004385ewy.19 for ; Sat, 17 Jul 2010 08:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=H99T2+RagH4QjcASsuzugkRV5Fni/F+WmXm4Hj1EKQE=; b=TTZJ+9tUkF1bXU4ooDYRxCqSLgxByj8zmLLg5d/Okhi0UVcEtAT0/YGMlJJ403skU5 qq159uPHrXGafolPDovlLjvTqsLZOhnwXcCkFD6dZnVHO2MYgMmE8D7mV61dHPKPZMe4 a/LTQZfESsWEFtUCrUFnTjzEzGLe3xEsFKNFU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=jZjXO/K1ZR4GtUPRVQk8s3knyCICQqBKoNR079Fhj9LwcJzvrJdksWuzJf9YBwgTLZ uopJ7gkWgzzVqwh7KE8duw7FIdMmSdGYzFubqvXuXxOOtZIHbc6P1B6f6bjSrtYKxNzA mLf0xNbUt+BuY1m+Oc1SKhrisoL0xUw2BEtRI= Received: by 10.213.15.12 with SMTP id i12mr2392575eba.55.1279380075417; Sat, 17 Jul 2010 08:21:15 -0700 (PDT) Received: from localhost ([213.87.81.197]) by mx.google.com with ESMTPS id a48sm28709428eei.18.2010.07.17.08.21.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Jul 2010 08:21:15 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Arnaldo Carvalho de Melo , "David S. Miller" , Gerrit Renker , dccp@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 5/5] net: dccp: fix sign bug Date: Sat, 17 Jul 2010 19:21:00 +0400 Message-Id: <1279380060-15394-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 'gap' is unsigned, so this code is wrong: gap = -new_head; ... if (gap > 0) { ... } Make 'gap' signed. The semantic patch that finds this problem (many false-positive results): (http://coccinelle.lip6.fr/) // @ r1 @ identifier f; @@ int f(...) { ... } @@ identifier r1.f; type T; unsigned T x; @@ *x = f(...) ... *x > 0 Signed-off-by: Kulikov Vasiliy --- net/dccp/ackvec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c index 2abddee..92a6fcb 100644 --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c @@ -201,7 +201,7 @@ static inline int dccp_ackvec_set_buf_head_state(struct dccp_ackvec *av, const unsigned int packets, const unsigned char state) { - unsigned int gap; + long gap; long new_head; if (av->av_vec_len + packets > DCCP_MAX_ACKVEC_LEN)