From patchwork Thu Jul 15 18:47:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 59023 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C9D64B6F3E for ; Fri, 16 Jul 2010 04:48:13 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934159Ab0GOSsH (ORCPT ); Thu, 15 Jul 2010 14:48:07 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:45460 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934126Ab0GOSsD (ORCPT ); Thu, 15 Jul 2010 14:48:03 -0400 Received: by eya25 with SMTP id 25so260892eya.19 for ; Thu, 15 Jul 2010 11:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=lj1B9ifLu+jteuAysN68oO0KaT7urP7LHUnhR02cwdo=; b=E5hKqmYt0ke2DESrIeTj4He8PyuwPZQUR8O234knTFVNlnOVF41rnyFQEh0oJAwKEp 1GpdPj2k+LcilhoLeqRLtgMYxSEd1ra4TRcBgEVd7dk7orXvQlFaXBXsDO3bNz8IjssA iYIkpkgBWhk+qfdBaw6ixZ5wdL2/0kUSA2Lk8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=MV4jdjb4TfhCci3Yg6RbAEMnhwUHgnJKBbio4I7jHtGQm1YrUOo0TRvUNnmt4sKWXy 002+cc1ZSzWxa4NBrEIPvOWXHRfE6Zl649MMNUoov7Ajvh2QQrYWeb/zcM+RbxPJjNkI fJQUaVwFiShLzHvE6T/v5+rDi2PsWK6NEmBW8= Received: by 10.213.20.10 with SMTP id d10mr51153ebb.87.1279219681512; Thu, 15 Jul 2010 11:48:01 -0700 (PDT) Received: from localhost ([213.87.80.236]) by mx.google.com with ESMTPS id v59sm10384841eeh.22.2010.07.15.11.47.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Jul 2010 11:48:01 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Stephen Hemminger , "David S. Miller" , Herbert Xu , YOSHIFUJI Hideaki , Eric Dumazet , bridge@lists.linux-foundation.org, netdev@vger.kernel.org Subject: [PATCH 7/8] net: bridge: fix sign bug Date: Thu, 15 Jul 2010 22:47:33 +0400 Message-Id: <1279219653-12791-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ipv6_skip_exthdr() can return error code that is below zero. 'offset' is unsigned, so it makes no sense. ipv6_skip_exthdr() returns 'int' so we can painlessly change type of offset to int. Signed-off-by: Kulikov Vasiliy Acked-by: Stephen Hemminger --- net/bridge/br_multicast.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 27ae946..85afcda 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br, struct icmp6hdr *icmp6h; u8 nexthdr; unsigned len; - unsigned offset; + int offset; int err; if (!pskb_may_pull(skb, sizeof(*ip6h)))